-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recurring tipping still occurs when Rewards are toggled off #2815
Labels
feature/rewards
priority/P2
A bad problem. We might uplift this to the next planned release.
QA Pass-Linux
QA Pass-macOS
QA Pass-Win64
QA/Test-Plan-Specified
QA/Yes
release-notes/include
Milestone
Comments
NejcZdovc
added
feature/rewards
priority/P2
A bad problem. We might uplift this to the next planned release.
QA/Yes
labels
Jan 4, 2019
18 tasks
NejcZdovc
added a commit
to brave/brave-core
that referenced
this issue
Jan 4, 2019
This was referenced Jan 4, 2019
Verification passed on
Verified passed with
Verification PASSED on
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
feature/rewards
priority/P2
A bad problem. We might uplift this to the next planned release.
QA Pass-Linux
QA Pass-macOS
QA Pass-Win64
QA/Test-Plan-Specified
QA/Yes
release-notes/include
Description
If you turn off Rewards via the toggle at the top of brave://rewards page, Recurring tipping can still occur if the table has sites in it. When Rewards are turned off, monthly tipping should not happen.
Steps to Reproduce
--rewards=reconcile-interval=15
(or a shorter amount of minutes if you can work quickly)Actual result:
contribution happens
Expected result:
contribution shouldn't happen
Reproduces how often:
Brave version (brave://version info)
Reproducible on current release:
Website problems only:
Additional Information
The text was updated successfully, but these errors were encountered: