Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recurring tipping still occurs when Rewards are toggled off #2815

Closed
NejcZdovc opened this issue Jan 4, 2019 · 1 comment · Fixed by brave/brave-core#1205
Closed

Recurring tipping still occurs when Rewards are toggled off #2815

NejcZdovc opened this issue Jan 4, 2019 · 1 comment · Fixed by brave/brave-core#1205

Comments

@NejcZdovc
Copy link
Contributor

Description

If you turn off Rewards via the toggle at the top of brave://rewards page, Recurring tipping can still occur if the table has sites in it. When Rewards are turned off, monthly tipping should not happen.

Steps to Reproduce

  1. Launch Brave with a fresh profile and --rewards=reconcile-interval=15(or a shorter amount of minutes if you can work quickly)
  2. Enable Rewards
  3. Fund your wallet, verify amount displays in browser.
  4. Visit some sites and add them to monthly list
  5. Turn off Rewards with toggle at the top of brave://rewards page
  6. Wait until the reconcile-interval time is met.

Actual result:

contribution happens

Expected result:

contribution shouldn't happen

Reproduces how often:

Brave version (brave://version info)

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds?

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
  • Is the issue reproducible on the latest version of Chrome?

Additional Information

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Jan 10, 2019

Verification passed on

Brave 0.58.20 Chromium: 71.0.3578.98 (Official Build) (64-bit)
Revision 15234034d19b85dcd9a03b164ae89d04145d8368-refs/branch-heads/3578@{#897}
OS Windows 10
  • Auto contribution did not went through, when Rewards switch turned off during auto contribution (before the completion of reconcile time interval)
  • Verified ac table is not cleared when Rewards switch is off and contribution did not go through
  • Verified auto contribution went through when Rewards is turned on

Verified passed with

Brave 0.58.20 Chromium: 71.0.3578.98 (Official Build) (64-bit)
Revision 15234034d19b85dcd9a03b164ae89d04145d8368-refs/branch-heads/3578@{#897}
OS Mac OS X
  • Verified monthly recurring tips did not go thru when Rewards was toggled off
  • Verified monthly recurring tips did go thru when Rewards was on and A-C was toggled off
  • Verified monthly recurring tips did go thru when Rewards was on and A-C was toggled on

Verification PASSED on Mint 19.1 x64 VM using the following build:

Brave 0.58.21 Chromium: 71.0.3578.98 (Official Build) (64-bit)
Revision 15234034d19b85dcd9a03b164ae89d04145d8368-refs/branch-heads/3578@{#897}
OS Linux
  • ensured that monthly recurring tips for verified and non-verified publishers didn't go through when Rewards was disabled (--rewards=reconcile-interval=3)
  • ensured that once the iniital 3min have gone by, re-enabled Rewards and ensured both verified and non-verified publishers were prcessed once the next three minutes have passed
  • ensured that monthly recurring tips for verified and non-verified publishers go through when Rewards is enabled and a-c was disabled/toggled off
  • ensured that monthly recurring tips for verified and non-verified publishers go through when Rewards is enabled and a-c was enabled/toggled on

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment