XHR requests canceled across a wide range of websites #2901

Swader · 2019-01-10T20:28:52Z

Full discussion in Twitter here: https://twitter.com/bitfalls/status/1082896409299505152

Version 0.59.20 Chromium: 72.0.3626.28 (Official Build) beta (64-bit)
Win10 x64.

Does not happen on OS X.
Does not happen in private browsing mode.
All extensions were OFF for the duration of reproducing the problems (I have only 3 extensions total - metamask, json viewer and Workona).
Shields are completely off during all these tests.

On certain websites, ajax requests get canceled for no apparent reason (code -3, ERR_ABORT).

Examples are: https://www.diffbot.com/careers and https://gitcoin.co/explorer?network=mainnet&keywords=nimbus&order_by=-web3_created

Here is a HAR reproduction for Diffbot: https://gist.github.com/Swader/a994365480ee63927eb4045163133f89

Example screenshot:

srirambv · 2019-01-11T03:48:50Z

This looks fixed on the new beta. Could have been the CORS issue which wasn't fixed in 0.59.20.

@Swader mind checking it on the new beta that went out yesterday?

Swader · 2019-01-11T10:36:33Z

Still happens, same conditions. All extensions and shields off. I recommend adding a debug output and a command line --debug flag to the executable before every ERR_ABORT emit so that we can find out when these canels are being triggered.

srirambv · 2019-01-11T10:42:14Z

Just to confirm you are still seeing this on 0.59.21 right?

Swader · 2019-01-11T10:43:03Z

Correct: Version 0.59.21 Chromium: 72.0.3626.28 (Official Build) beta (64-bit)

srirambv · 2019-01-11T10:51:19Z

@btlechowski @GeetaSarvadnya could you guys give it a try on Windows?

cc: @iefremov @simonhong

iefremov · 2019-01-11T11:01:07Z

I don't think its the CORS issue, looks like smth different.
Maybe check this behavior in Chrome?

srirambv · 2019-01-11T11:01:55Z

I can't reproduce the issue on Linux with the same build.

Swader · 2019-01-11T11:04:33Z

It works in latest Chrome and Opera.
It does not happen on any other OS, or even in private mode on Win+Brave.

iefremov · 2019-01-11T11:14:58Z

Thanks for checking this. Probably it is also worth checking in Chrome version corresponding to the problematic Brave build (Chromium: 72.0.3626.28) @srirambv

Swader · 2019-01-11T17:04:52Z

Another example: https://prvikvadrat.hr/

Swader · 2019-01-14T17:04:00Z

Another example on Github. A few refreshes with cache off helped.

cndouglas · 2019-01-14T19:02:39Z

+1 from me (#2930).

Happens on the current beta (0.59.x) and dev (0.60.x) releases, but not the current public release (0.58.x).
Happens on macOS (10.14)
Seems to happen with a fresh profile after restarting the browser at least once
Turning off shields does not help
More examples of websites:
- https://github.com while logged in (Recent Activity section does not load)
- https://hstspreload.org/?domain=brave.com (HSTS check does not finish loading)
- https://brave.com/jobs/ (job listings do not load)

bbondy · 2019-01-15T04:50:51Z

this seems serious and new based on ^, putting P1 and putting as release/blocking.

bsclifton · 2019-01-15T06:59:21Z

@liunkae can you please update to latest? I'm curious if recent fixes resolve this problem for you (works for me!™)

For what it's worth, I'm on DEV channel (0.60.12)

iefremov · 2019-01-15T07:43:08Z

Can't reproduce on Dev/Beta on MacOS.

Anyone with a stable repro, please save a netlog. To do this:

Open brave://net-export/
Click "Start logging to disk"
Reproduce the bug in some other tab
Return to brave://net-export, click "Stop logging", attach the resulted file to this ticket :)

Thanks

Swader · 2019-01-15T08:01:47Z

Here's an older export from me.
chrome-net-export-log.zip

cndouglas · 2019-01-15T20:17:24Z

Here's a netlog: chrome-net-export-log.json.zip

Still reproduces (100% of the time) for me with the following:

Brave | 0.60.13 Chromium: 72.0.3626.53 (Official Build) dev(64-bit)
Revision | 98434e6cd182d68ce396daa92e9c6310422e6763-refs/branch-heads/3626@{#620}
OS | Mac OS X
macOS version 10.14.2

Steps to reproduce:

Start with a fresh profile.
Quit the browser.
Start Brave again.
Go to https://brave.com/jobs
Notice that the job listings do not load, even with shields off:

The developer console shows that one of the resources was canceled:

bbondy · 2019-01-15T20:55:48Z

We tracked it down to some code for the DOM distiller. Working on a fix.

kjozwiak · 2019-01-16T21:18:25Z

Removed OS/Windows as this is affecting macOS as well.

… called. This maintains the original behavior from https://chromium.googlesource.com/chromium/src/+/fb688daf52cef3bb041634888583ee2c28c8af66%5E%21/components/dom_distiller/content/distiller_page_web_contents.cc without breaking sites that use the original webcontents Fix brave/brave-browser#2991 Fix brave/brave-browser#2901

srirambv · 2019-01-18T10:32:45Z

Verification passed on

Brave	0.59.25 Chromium: 72.0.3626.53 (Official Build) beta(64-bit)
Revision	98434e6cd182d68ce396daa92e9c6310422e6763-refs/branch-heads/3626@{#620}
OS	Linux

Verified steps from original issue
Verified steps from XHR requests canceled across a wide range of websites #2901 (comment)

Verification passed on

Brave	0.59.25 Chromium: 72.0.3626.53 (Official Build) beta (64-bit)
Revision	98434e6cd182d68ce396daa92e9c6310422e6763-refs/branch-heads/3626@{#620}
OS	Windows 10

Verified steps from original issue
Verified steps from XHR requests canceled across a wide range of websites #2901 (comment)

Verification PASSED on macOS 10.14.2 x64 using the following build:

Brave	0.59.28 Chromium: 72.0.3626.64 (Official Build) beta(64-bit)
Revision	eaa9668e80ce5405e7f1902579558ea725c06ca1-refs/branch-heads/3626@{#708}
OS	Mac OS X

Verified steps from XHR requests canceled across a wide range of websites #2901 (comment)
Verified steps from XHR requests canceled across a wide range of websites #2901 (comment)
Verified steps from XHR requests canceled across a wide range of websites #2901 (comment)
Verified steps from XHR requests canceled across a wide range of websites #2901 (comment)

Swader · 2019-01-18T14:05:23Z

Please update issue to ping us when this lands in beta on Win

bbondy · 2019-01-18T14:16:51Z

It's already updated on dev and beta

Swader · 2019-01-18T14:48:02Z

Indeed it seems to work now. Can you explain how, without an update process?

srirambv · 2019-01-18T16:41:18Z

@Swader your app should have been updated to 0.59.25. Could you check brave://version?

Swader · 2019-01-20T08:54:58Z

It did indeed, but I don't remember the update process having happened. Might have occurred between a PC restart. Anyway thanks looks good now!

srirambv added the needs-more-info The report requires more detail before we can decide what to do with this issue. label Jan 11, 2019

srirambv added the needs-investigation A bug not 100% confirmed/fixed label Jan 11, 2019

srirambv added this to the 1.x Backlog milestone Jan 11, 2019

srirambv added the OS/Windows label Jan 11, 2019

cndouglas mentioned this issue Jan 14, 2019

Many websites are not loading completely after browser restart #2930

Closed

bbondy added the priority/P1 A very extremely bad problem. We might push a hotfix for it. label Jan 15, 2019

bbondy modified the milestones: 1.x Backlog, 0.59.x - Beta Jan 15, 2019

bbondy added the release/blocking label Jan 15, 2019

iefremov self-assigned this Jan 15, 2019

kjozwiak removed the OS/Windows label Jan 16, 2019

bridiver mentioned this issue Jan 16, 2019

only call Stop when DistillerPageWebContents::CreateNewWebContents is… brave/brave-core#1361

Merged

18 tasks

bridiver mentioned this issue Jan 16, 2019

only call Stop when DistillerPageWebContents::CreateNewWebContents is… brave/brave-core#1362

Merged

18 tasks

bridiver mentioned this issue Jan 16, 2019

only call Stop when DistillerPageWebContents::CreateNewWebContents is… brave/brave-core#1363

Merged

18 tasks

bridiver closed this as completed in brave/brave-core#1361 Jan 16, 2019

srirambv added the QA Pass-Linux label Jan 18, 2019

GeetaSarvadnya added the QA Pass-Win64 label Jan 18, 2019

kjozwiak added QA/Yes QA Pass-macOS release-notes/exclude and removed needs-more-info The report requires more detail before we can decide what to do with this issue. needs-investigation A bug not 100% confirmed/fixed labels Jan 21, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

XHR requests canceled across a wide range of websites #2901

XHR requests canceled across a wide range of websites #2901

Swader commented Jan 10, 2019

srirambv commented Jan 11, 2019 •

edited

Loading

Swader commented Jan 11, 2019

srirambv commented Jan 11, 2019

Swader commented Jan 11, 2019

srirambv commented Jan 11, 2019 •

edited

Loading

iefremov commented Jan 11, 2019

srirambv commented Jan 11, 2019

Swader commented Jan 11, 2019

iefremov commented Jan 11, 2019

Swader commented Jan 11, 2019

Swader commented Jan 14, 2019

cndouglas commented Jan 14, 2019 •

edited

Loading

bbondy commented Jan 15, 2019

bsclifton commented Jan 15, 2019 •

edited

Loading

iefremov commented Jan 15, 2019

Swader commented Jan 15, 2019

cndouglas commented Jan 15, 2019

bbondy commented Jan 15, 2019

kjozwiak commented Jan 16, 2019

srirambv commented Jan 18, 2019 •

edited by kjozwiak

Loading

Swader commented Jan 18, 2019

bbondy commented Jan 18, 2019

Swader commented Jan 18, 2019

srirambv commented Jan 18, 2019

Swader commented Jan 20, 2019

XHR requests canceled across a wide range of websites #2901

XHR requests canceled across a wide range of websites #2901

Comments

Swader commented Jan 10, 2019

srirambv commented Jan 11, 2019 • edited Loading

Swader commented Jan 11, 2019

srirambv commented Jan 11, 2019

Swader commented Jan 11, 2019

srirambv commented Jan 11, 2019 • edited Loading

iefremov commented Jan 11, 2019

srirambv commented Jan 11, 2019

Swader commented Jan 11, 2019

iefremov commented Jan 11, 2019

Swader commented Jan 11, 2019

Swader commented Jan 14, 2019

cndouglas commented Jan 14, 2019 • edited Loading

bbondy commented Jan 15, 2019

bsclifton commented Jan 15, 2019 • edited Loading

iefremov commented Jan 15, 2019

Swader commented Jan 15, 2019

cndouglas commented Jan 15, 2019

bbondy commented Jan 15, 2019

kjozwiak commented Jan 16, 2019

srirambv commented Jan 18, 2019 • edited by kjozwiak Loading

Swader commented Jan 18, 2019

bbondy commented Jan 18, 2019

Swader commented Jan 18, 2019

srirambv commented Jan 18, 2019

Swader commented Jan 20, 2019

srirambv commented Jan 11, 2019 •

edited

Loading

srirambv commented Jan 11, 2019 •

edited

Loading

cndouglas commented Jan 14, 2019 •

edited

Loading

bsclifton commented Jan 15, 2019 •

edited

Loading

srirambv commented Jan 18, 2019 •

edited by kjozwiak

Loading