-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Videos don't play on videoportal.joj.sk #2931
Comments
Did a comparison between Brave and an ABP'd Chrome, and managed to trace the issue back to how we treat ima3.js. ABP blocks the request (a failure the system can tolerate by simply leaving out the ads from the video), while we use a 307 internal redirect to an empty data URL which suggests to the code that ima should be loaded. I'm not super familiar with the pros/cons of blocking the 307 way, but this time that's the issue. It also causes console errors in #3031 but there it's not a big thing. CC @bbondy |
@mrzealot I think ultimately we'll let the matching block rule decide to block or 200 ok, but default to 200 ok. |
@bbondy PR for 0.63.x is not merged. brave/brave-core#2012 |
Yep I was going to rebase today and reland tomorrow. Sorry for the delay. |
Verification passed on
Verification passed on
|
Description
A user on Twitter has reported that videos don't play properly on videoportal.joj.sk.
Steps to Reproduce
Actual result:
Video doesn't play; appears to be stuck loading.
Expected result:
Video loads as needed, and begins playing promptly.
Reproduces how often:
Easily.
Brave version (brave://version info)
0.58.21
Reproducible on current release:
Yes
Website problems only:
Additional Information
In order to play the videos, the user must disable 'ads and trackers blocked' via the site shields panel.
The text was updated successfully, but these errors were encountered: