Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Videos don't play on videoportal.joj.sk #2931

Closed
jonathansampson opened this issue Jan 12, 2019 · 5 comments · Fixed by brave/brave-core#1981
Closed

Videos don't play on videoportal.joj.sk #2931

jonathansampson opened this issue Jan 12, 2019 · 5 comments · Fixed by brave/brave-core#1981
Labels
feature/shields/adblock Blocking ads & trackers with Shields priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include webcompat/not-shields-related Sites are breaking because of something other than Shields. webcompat/shields Shields is breaking a website.

Comments

@jonathansampson
Copy link
Contributor

Description

A user on Twitter has reported that videos don't play properly on videoportal.joj.sk.

Steps to Reproduce

  1. Navigate to https://videoportal.joj.sk/vsetko-co-mam-rad/epizoda/61134-vsetko-co-ma-ander-rad
  2. Click to play the video

Actual result:

Video doesn't play; appears to be stuck loading.

Expected result:

Video loads as needed, and begins playing promptly.

Reproduces how often:

Easily.

Brave version (brave://version info)

0.58.21

Reproducible on current release:

Yes

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields? Yes
  • Is the issue reproducible on the latest version of Chrome? No

Additional Information

In order to play the videos, the user must disable 'ads and trackers blocked' via the site shields panel.

@jonathansampson jonathansampson added feature/shields/adblock Blocking ads & trackers with Shields webcompat/shields Shields is breaking a website. labels Jan 12, 2019
@bbondy bbondy added this to the 1.x Backlog milestone Jan 13, 2019
@mrzealot
Copy link

Did a comparison between Brave and an ABP'd Chrome, and managed to trace the issue back to how we treat ima3.js. ABP blocks the request (a failure the system can tolerate by simply leaving out the ads from the video), while we use a 307 internal redirect to an empty data URL which suggests to the code that ima should be loaded.

I'm not super familiar with the pros/cons of blocking the 307 way, but this time that's the issue. It also causes console errors in #3031 but there it's not a big thing. CC @bbondy

@bbondy bbondy added the webcompat/not-shields-related Sites are breaking because of something other than Shields. label Jan 22, 2019
@bbondy
Copy link
Member

bbondy commented Jan 23, 2019

@mrzealot I think ultimately we'll let the matching block rule decide to block or 200 ok, but default to 200 ok.

@rebron rebron removed this from the 1.x Backlog milestone Feb 7, 2019
@bbondy bbondy added the priority/P3 The next thing for us to work on. It'll ride the trains. label Mar 5, 2019
@bbondy bbondy added the QA/Yes label Mar 19, 2019
@bbondy bbondy added this to the 0.63.x - Beta milestone Mar 31, 2019
@btlechowski
Copy link

@bbondy PR for 0.63.x is not merged. brave/brave-core#2012

@bbondy
Copy link
Member

bbondy commented Apr 4, 2019

Yep I was going to rebase today and reland tomorrow. Sorry for the delay.

@srirambv
Copy link
Contributor

srirambv commented Apr 9, 2019

Verification passed on

Brave 0.63.35 Chromium: 74.0.3729.61 (Official Build) beta(64-bit)
Revision 5df2c8936783bd7575987e45d72a92fcf528496b-refs/branch-heads/3729@{#645}
OS Linux
  • Verified the video loaded without having to change default shields settings
  • Verified the page loaded with 200 OK status in network tab

Verification passed on

Brave 0.63.35 Chromium: 74.0.3729.61 (Oficjalna wersja) beta (64-bitowa)
Wersja 5df2c8936783bd7575987e45d72a92fcf528496b-refs/branch-heads/3729@{#645}
System operacyjny Windows 10 OS Build 17134.523
  • Verified the video loaded without having to change default shields settings
  • Verified the page loaded with 200 OK status in network tab

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/shields/adblock Blocking ads & trackers with Shields priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include webcompat/not-shields-related Sites are breaking because of something other than Shields. webcompat/shields Shields is breaking a website.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants