Upgrade from Chromium 113 to Chromium 114

[emerick]

Upgrade from Chromium 113 to Chromium 114

https://chromium.googlesource.com/chromium/src/+log/113.0.5672.77..114.0.5735.16/?pretty=fuller&n=10000

QA tests:
This is a major Chromium version bump, please do full passes.

Desktop Affected areas:

• Verify creating a new profile
• Verify that memory saver feature is still exposed in brave://settings
• Verify that Ads notifications continue to look/work as expected
• Verify that UI for tabs continues to look as expected
• Verify that vertical tabs continue to work as expected
• Verify that side panel continues to work as expected
• Verify brave://settings has all expected pages/functionality
• Verify that downloads dropdown/panel continues to work as expected
• Verify that new tab button (+) works as expected
• Verify that https upgrades work as expected

iOS Affected areas:

• Normal iOS-related testing

Android Affected areas:

• Double check connection to Uphold/Gemini wallet works
• Check VPN subscription works
• Safe browsing prefs (check info button redirects to a proper page)
• Tab overview mode on tablets

[GeetaSarvadnya]

Verification PASSED on

Brave | 1.53.43 Chromium: 114.0.5735.26 (Official Build) nightly (64-bit)
-- | --
Revision | 7075cbb66f0542ac3e01ddfde6b813e7d61118a5-refs/branch-heads/5735@{#454}
OS | Windows 10 Version 21H2 (Build 19044.2965)

• Logged Spacing issue in on exit tab in Clear browsing data modal #30394
• Logged Remove Block third-party cookies toggle from Cookies and site data popup in lock icon  #30396
• Logged Radio button color changes in few places in CR 114 build #30399

Verify creating a new profile_PASSED

• Confirmed that user can create new profile
• Confirmed that user can create multiple profiles
• Confirmed that user can switch between the multiple profiles

Verify that memory saver feature is still exposed in brave://settings_PASSED

• Confirmed that Memory Saver is toggled to Off by default under brave://settings/system
  

Verify that Ads notifications continue to look/work as expected_PASSED

• Confirmed that ads are served when rewards is enabled
• Confirmed that ad notifications are auto dismissed after 2 mins (160 secs)
• Confirmed that click on the ad notification opens up the ads landing page
• Confirmed that users are rewarded for viewing the ads
• Confirmed that ad notification count and estimated ads earning are show correctly on the Ads panel

Example	Example

Verify that UI for tabs continues to look as expected_PASSED

• Confirmed that UI for horizontal tabs works/looks as expected
• Confirmed that UI for vertical tabs works/looks as expected
• Confirmed that Tab hover mode options works as expected
• Confirmed that show tab search settings works as expected
  

Verify that vertical tabs continue to work as expected_PASSED

General testing on Vertical tabs :

• Confirmed that Use vertical tabs settings is added in Tabs section under brave://settings/appearance
• Confirmed that tabs orientation changed to vertical when user toggle the Use vertical tabs settings via brave://settings/appearance
• Verified that sites can be added to vertical tab by clicking on the + New tab or Ctrl+T
• Right click on any site added in the vertical tab shows the site context menu options
• Verified that reading list and vertical tabs cab be enabled at the same time
• Right click on any site and select Add tab to reading list context menu option and ensured site can be added to the reading list
• Right click on any site and select Add a tab to new group and ensured that the selected site can be added to new tab group
• Right click on the sites in vertical tab and select Add a tab to new group and then created tab (e.g test which I have created in my testing) group and ensured that sites got added to the tab group test
• Verified that created tab group can be collapsed/expanded, when the group is expanded sites added in tab groups are shown
• Right click on any site in vertical tab and select Move tab to another window and ensured that tab is opened in an new window
• When a tab is moved to the new window, if user try to move another tab to new window, user get option to move the tab to the existing (2nd window) or new window, ensured both options works fine
• Right click on any site in vertical tab and select Reload context menu option and ensured site gets reloaded/refreshed
• Right click on any site in vertical tab and select Duplicate context menu option and ensured duplicate tab got added to the tab group
• Right click on any site in vertical tab and select Pin context menu option and ensured site pinned in the tab group and right clicked on the pinned tab and ensured Unpin option is shown
• Ensured that pinned site can be unpinned by clicking on the Unpin option
• Right click on any YT site in vertical tab and select mute context menu option and ensured site is muted and mute option is shown in the URL bar and video is playing in an muted mode.
• Ensured that YT videos can be unmuted by clicking on the Unmute option
• Ensured that Close, Close other tabs, Close tabs to the right and Reopen closed tabs works as expected
• Ensured that the tab Bookmarls all context menu works as expected
• Ensured that tabs can be drag and drop in an vertical tab
• Ensured that vertical tab cab be collapsed/expanded, when vertical tabs is expand the tabs with site name and url is shown, when vertical tab cab be collapsed, the site favicons are shown in the vertical tabs

Toggle "Use Vertical tabs" settings ON/OFF

• Confirmed that Use Vertical tabs toggle ON/OFF works as expected
• Confirmed that once the Use Vertical tabs toggle is OFF, tabs are shown in horizontal view
• Confirmed that when tabs are switched between vertical/horizontal, the created tab groups are not lost
• Confirmed that when tabs are switched between vertical/horizontal, the pinned tabs are not lost

Example	Example

Show title bar

• Confirmed that title bar is shown when the Show title bar toggle is turned ON
• Confirmed that title bar is NOT shown when the Show title bar toggle is turned OFF

Example	Example	Example	Example

Float on mouseover

• Confirmed that Float on mouseover settings is enabled by default under brave://settings/appearance
• When vertical tabs are in minimized mode, mouseover on the vertical tabs shows the vertical tabs in floating mode
• Confirmed that mouseover on the vertical tabs DOESN'T shows the vertical tabs in floating mode when the settings Float on mouseover is unchecked
  

Tab hover mode

• Confirmed that Card Tab hover mode settings works as expected on vertical tabs
• Confirmed that Card with preview Tab hover mode settings works as expected on vertical tabs
• Confirmed that Tooltip Tab hover mode settings works as expected on vertical tabs
  

Show tab search button

• Confirmed that Show tab search button settings works as expected with Vertical tabs enable
• Confirmed that able to search particula tabs using search tab option
  

Verify that side panel continues to work as expected_PASSED

• Confirmed that sidebar is shown by default in the nightly channel
• Confirmed that Reading list icon is added to the sidebar menu
• Confirmed that reading list panel is shown when user click on the Reading list icon in the sidebar menu
• Confirmed that user can add the list of websites to the reading list by clicking on the +Add current tab
• Confirmed that user can add the list of websites to the reading list by right clicking on the tab and choose the option Add tab to the reading list
• Confirmed that reading list panel can be hidden by clicking on the Reading list icon in the sidebar menu
• Confirmed that reading list icon is shown in the URL bar, next to wallet icon
• Confirmed that user can enable/disable the reading list by clicking on the reading list icon (shown in the URL bar)
• Confirmed that reading list is shown in all the window types (Normal, PT, TOR and Guest window)
• Websites can't be added to reading list in Guest, encountered Unable to add a site to reading list in Guest window as Add to current tab option is not getting activated #24930
• Confirmed that sites can be segregated to Read and Unread list
• Confirmed that sites can be deleted from the reading list
• Confirmed that tooltip is shown correctly for each menu item in sidebar
• Confirmed that click on each sidepanel button Brave Talk, wallet, Bookmarks and REading list works as expected

Verify brave://settings has all expected pages/functionality_PASSED

• Covered the testing in Settings comparison section below

Verify that downloads dropdown/panel continues to work as expected_PASSED

• Confirmed download functionality works as expected
• Confirmed the progress-meter color is "blurple" and matches the download button
• Confirmed toolbar download button style is as expected
• Confirmed that Shown in folder opens up the download file path
• Encountered Downloads bubble doesn't popup when the download is blocked/dangerous (safe browsing disabled) #29651

Example	Example

Verify that new tab button (+) works as expected_PASSED

• Confirmed that click new tab button (+) opens up the new tab
• Confirmed that new tab button (+) works as expected in Horizontal tabs orientation
• Confirmed that new tab button (+) works as expected in Vertical tabs orientation
• Confirmed that new tab button (+) works as expected in Normal/PT/TOR and Guest window types

Horizontal new tab button (+)	Vertical new tab button (+)

Verify that https upgrades work as expected_PASSED

Case 1: Ensured that connections were upgraded to HTTPS_PASSED

1. launched/restarted 1.53.x
2. visited http://upgradable.arthuredelstein.net/ in a Normal window and ensured that Upgrade connections to HTTPS was selected in the Shields panel
3. ensured that http://upgradable.arthuredelstein.net -> https://upgradable.arthuredelstein.net
4. opened a Private window and visited http://upgradable.arthuredelstein.net/ and ensured Upgrade connections to HTTPS
5. ensured that http://upgradable.arthuredelstein.net -> https://upgradable.arthuredelstein.net
6. Open http://http.badssl.com/ in normal window and ensured that the site is NOT upgraded to https
7. Open http://insecure.arthuredelstein.net/ in normal window and ensured that the site is NOT upgraded to https

Ensured that connections were upgraded to HTTPS

step 3	step 5	step 6	step 7

Case 2: Only connect using HTTPS_PASSED

1. launched/restarted 1.53.x
2. visited http://upgradable.arthuredelstein.net/ switched HTTPS upgrades to Only connect with HTTPS
3. ensured that http://upgradable.arthuredelstein.net -> https://upgradable.arthuredelstein.net
4. opened a Private window and visited http://upgradable.arthuredelstein.net/ and ensured Only connect with HTTPS
5. ensured that http://upgradable.arthuredelstein.net -> https://upgradable.arthuredelstein.net

Ensured that connections used HTTPS

step 2	step 3	step 4	step 5

Case 3: Don't upgrade HTTPS connections_PASSED

1. launched/restarted 1.53.x
2. enable #https-by-default via brave://flags
3. visited http://upgradable.arthuredelstein.net/ and switched HTTPS upgrades to Don't upgrade HTTPS connections in the Shields panel
4. reloaded http://upgradable.arthuredelstein.net/ and ensured that the website was not being upgraded to HTTPS
5. opened a Private window and visited http://upgradable.arthuredelstein.net/ and ensured Upgrade connections to HTTPS was selected in the Shields panel
6. ensured that http://upgradable.arthuredelstein.net -> https://upgradable.arthuredelstein.net

Ensured that Don't upgrade HTTPS connections is NOT being used

step 4	step 6

---

Settings comparison

• No new settings are added as part of CR 114
• The settings Autofill is renamed to Autofill and passwords and which is same as Chrome 114 (asked a clarification in https://bravesoftware.slack.com/archives/CU5UXM3EC/p1684307593162539?thread_ts=1683915585.881759&cid=CU5UXM3EC)
• The new cookies settings is been added in lock icon, logged Remove Block third-party cookies toggle from Cookies and site data popup in lock icon  #30396
  

Components updater

• No new components are added as part of CR 114
• Components are updates successfully without any error

1.51.114 Chromium: 113.0.5672.92	1.53.43 Chromium: 114.0.5735.26

Brave startup calls

• Confirmed that only brave domains are listed in the Charles when the nightly build is launched with a clean profile
• Confirmed no calls to google, gstatic, etc domains when the nightly build is launched with a clean profile

[Uni-verse]

Verified on Samsung Galaxy S21 5G using version

Brave	1.53.50 Chromium: 114.0.5735.26 (Official Build) canary (64-bit) 
Revision	7075cbb66f0542ac3e01ddfde6b813e7d61118a5-refs/branch-heads/5735@{#454}
OS	Android 13; Build/TP1A.220624.014; 33; REL

Wallet connection

• Ensured connecting brave rewards wallet works.
• Ensured balances are correctly shown.
• Ensured contributions are going through.

Example	Example

VPN subscription

Will be tested in brave/brave-core#18516 or associated issues.

Safe Browsing

• Ensured safe browsing warning interstitial is shown for dangerous sites.

Example	Example	Example	Example

Tab overview

• Ensured tabs can be selected, opened/closed and bookmarked using options in tab overview
• Ensured switching tabs in tab overview works
• Ensured grouping/ungrouping works in tab overview

Encountered: #30437

C113	C114	Example	Example	Example

[Uni-verse]

Verified on Samsung Galaxy Tab S7 using version

Brave	1.53.47 Chromium: 114.0.5735.26 (Official Build) canary (64-bit) 
Revision	7075cbb66f0542ac3e01ddfde6b813e7d61118a5-refs/branch-heads/5735@{#454}
OS	Android 13; Build/TP1A.220624.014; 33; REL

Wallet connection

• Ensured connecting brave rewards wallet works.
• Ensured balances are correctly shown.
• Ensured contributions are going through.

Example	Example

VPN subscription

Will be tested in brave/brave-core#18516 or associated issues.

Safe Browsing

• Ensured safe browsing warning interstitial is shown for dangerous sites.

Example	Example	Example

Tab overview

• Ensured tabs can be selected, opened/closed and bookmarked using options in tab overview
• Ensured switching tabs in tab overview works
• Ensured grouping/ungrouping works in tab overview

Encountered: #30437 (mobile specific)

Example	Example	Example	Example	Example

[kjozwiak]

The above requires 1.52.107 or higher for 1.52.x verification 👍

[stephendonner]

Verification PASSED using

Brave	1.52.108 Chromium: 114.0.5735.26 (Official Build) beta (x86_64)
Revision	7075cbb66f0542ac3e01ddfde6b813e7d61118a5-refs/branch-heads/5735@{#454}
OS	macOS Version 11.7.7 (Build 20G1345)

Verify creating a new profile - PASSED

• Confirmed that user can create new profile
• Confirmed that user can create multiple profiles
• Confirmed that user can switch between the multiple profiles

Verify that memory saver feature is still exposed in brave://settings - PASSED

• Confirmed that Memory Saver is toggled to Off by default under brave://settings/system

Verify that Ads notifications continue to look/work as expected - PASSED

• Confirmed that ads are served when rewards is enabled
• Confirmed that ad notifications are auto dismissed after 2 mins (160 secs)
• Confirmed that click on the ad notification opens up the ads landing page
• Confirmed that users are rewarded for viewing the ads
• Confirmed that ad notification count and estimated ads earning are show correctly on the Ads panel

Example	Example

Verify that UI for tabs continues to look as expected - PASSED

• Confirmed that UI for horizontal tabs works/looks as expected
• Confirmed that UI for vertical tabs works/looks as expected
• Confirmed that Tab hover mode options works as expected
• Confirmed that show tab search settings works as expected

Example	Example	Example

Verify that vertical tabs continue to work as expected - PASSED

General testing on Vertical tabs :

• Confirmed that Use vertical tabs settings is added in Tabs section under brave://settings/appearance
• Confirmed that tabs orientation changed to vertical when user toggle the Use vertical tabs settings via brave://settings/appearance
• Verified that sites can be added to vertical tab by clicking on the + New tab or Ctrl+T
• Right click on any site added in the vertical tab shows the site context menu options
• Verified that reading list and vertical tabs cab be enabled at the same time
• Right click on any site and select Add tab to reading list context menu option and ensured site can be added to the reading list
• Right click on any site and select Add a tab to new group and ensured that the selected site can be added to new tab group
• Right click on the sites in vertical tab and select Add a tab to new group and then created tab (e.g test which I have created in my testing) group and ensured that sites got added to the tab group test
• Verified that created tab group can be collapsed/expanded, when the group is expanded sites added in tab groups are shown
• Right click on any site in vertical tab and select Move tab to another window and ensured that tab is opened in an new window
• When a tab is moved to the new window, if user try to move another tab to new window, user get option to move the tab to the existing (2nd window) or new window, ensured both options works fine
• Right click on any site in vertical tab and select Reload context menu option and ensured site gets reloaded/refreshed
• Right click on any site in vertical tab and select Duplicate context menu option and ensured duplicate tab got added to the tab group
• Right click on any site in vertical tab and select Pin context menu option and ensured site pinned in the tab group and right clicked on the pinned tab and ensured Unpin option is shown
• Ensured that pinned site can be unpinned by clicking on the Unpin option
• Right click on any YT site in vertical tab and select mute context menu option and ensured site is muted and mute option is shown in the URL bar and video is playing in an muted mode.
• Ensured that YT videos can be unmuted by clicking on the Unmute option
• Ensured that Close, Close other tabs, Close tabs to the right and Reopen closed tabs works as expected
• Ensured that the tab Bookmarls all context menu works as expected
• Ensured that tabs can be drag and drop in an vertical tab
• Ensured that vertical tab cab be collapsed/expanded, when vertical tabs is expand the tabs with site name and url is shown, when vertical tab cab be collapsed, the site favicons are shown in the vertical tabs

Toggle "Use Vertical tabs" settings ON/OFF

• Confirmed that Use Vertical tabs toggle ON/OFF works as expected
• Confirmed that once the Use Vertical tabs toggle is OFF, tabs are shown in horizontal view
• Confirmed that when tabs are switched between vertical/horizontal, the created tab groups are not lost
• Confirmed that when tabs are switched between vertical/horizontal, the pinned tabs are not lost

Example	Example

Show title bar

• Confirmed that title bar is shown when the Show title bar toggle is turned ON
• Confirmed that title bar is NOT shown when the Show title bar toggle is turned OFF

Example	Example	Example	Example

Float on mouseover

• Confirmed that Float on mouseover settings is enabled by default under brave://settings/appearance
• When vertical tabs are in minimized mode, mouseover on the vertical tabs shows the vertical tabs in floating mode
• Confirmed that mouseover on the vertical tabs DOESN'T shows the vertical tabs in floating mode when the settings Float on mouseover is unchecked

Tab hover mode

• Confirmed that Card Tab hover mode settings works as expected on vertical tabs
• Confirmed that Card with preview Tab hover mode settings works as expected on vertical tabs
• Confirmed that Tooltip Tab hover mode settings works as expected on vertical tabs

Show tab search button

• Confirmed that Show tab search button settings works as expected with Vertical tabs enable
• Confirmed that able to search particular tabs using search tab option

Verify that side panel continues to work as expected - PASSED

• Confirmed that sidebar is shown by default in the nightly channel
• Confirmed that Reading list icon is added to the sidebar menu
• Confirmed that reading list panel is shown when user click on the Reading list icon in the sidebar menu
• Confirmed that user can add the list of websites to the reading list by clicking on the +Add current tab
• Confirmed that user can add the list of websites to the reading list by right clicking on the tab and choose the option Add tab to the reading list
• Confirmed that reading list panel can be hidden by clicking on the Reading list icon in the sidebar menu
• Confirmed that reading list icon is shown in the URL bar, next to wallet icon
• Confirmed that user can enable/disable the reading list by clicking on the reading list icon (shown in the URL bar)
• Confirmed that reading list is shown in all the window types (Normal, PT, TOR and Guest window)
• Websites can't be added to reading list in Guest, encountered Unable to add a site to reading list in Guest window as Add to current tab option is not getting activated #24930
• Confirmed that sites can be segregated to Read and Unread list
• Confirmed that sites can be deleted from the reading list
• Confirmed that tooltip is shown correctly for each menu item in sidebar
• Confirmed that click on each sidepanel button Brave Talk, wallet, Bookmarks and Reading list works as expected

Example	Example	Example	Example

Verify brave://settings has all expected pages/functionality - PASSED

• Covered the testing in Settings comparison section below

Verify that downloads dropdown/panel continues to work as expected - PASSED

• Confirmed download functionality works as expected
• Confirmed the progress-meter color is "blurple" and matches the download button
• Confirmed toolbar download button style is as expected
• Confirmed that Shown in folder opens up the download file path
• Encountered Downloads bubble doesn't popup when the download is blocked/dangerous (safe browsing disabled) #29651

Example	Example

Verify that the new tab button (+) works as expected - PASSED

• Confirmed that click new tab button (+) opens up the new tab
• Confirmed that new tab button (+) works as expected in Horizontal tabs orientation
• Confirmed that new tab button (+) works as expected in Vertical tabs orientation
• Confirmed that new tab button (+) works as expected in Normal/PT/TOR and Guest window types

Horizontal new tab button (+)	Vertical new tab button (+)

Verify that https upgrades work as expected - PASSED

Case 1: Ensured that connections were upgraded to HTTPS - PASSED

1. launched/restarted 1.52.x
2. visited http://upgradable.arthuredelstein.net/ in a Normal window and ensured that Upgrade connections to HTTPS was selected in the Shields panel
3. ensured that http://upgradable.arthuredelstein.net -> https://upgradable.arthuredelstein.net
4. opened a Private window and visited http://upgradable.arthuredelstein.net/ and ensured Upgrade connections to HTTPS
5. ensured that http://upgradable.arthuredelstein.net -> https://upgradable.arthuredelstein.net
6. Open http://http.badssl.com/ in normal window and ensured that the site is NOT upgraded to https
7. Open http://insecure.arthuredelstein.net/ in normal window and ensured that the site is NOT upgraded to https

Ensured that connections were upgraded to HTTPS

step 3	step 5	step 6	step 7

Case 2: Only connect using HTTPS - PASSED

1. launched/restarted 1.52.x
2. visited http://upgradable.arthuredelstein.net/ switched HTTPS upgrades to Only connect with HTTPS
3. ensured that http://upgradable.arthuredelstein.net -> https://upgradable.arthuredelstein.net
4. opened a Private window and visited http://upgradable.arthuredelstein.net/ and ensured Only connect with HTTPS
5. ensured that http://upgradable.arthuredelstein.net -> https://upgradable.arthuredelstein.net

Ensured that connections used HTTPS

step 2	step 3	step 4	step 5

Case 3: Don't upgrade HTTPS connections - PASSED

1. launched/restarted 1.52.x
2. enable #https-by-default via brave://flags
3. visited http://upgradable.arthuredelstein.net/ and switched HTTPS upgrades to Don't upgrade HTTPS connections in the Shields panel
4. reloaded http://upgradable.arthuredelstein.net/ and ensured that the website was not being upgraded to HTTPS
5. opened a Private window and visited http://upgradable.arthuredelstein.net/ and ensured Upgrade connections to HTTPS was selected in the Shields panel
6. ensured that http://upgradable.arthuredelstein.net -> https://upgradable.arthuredelstein.net

Ensured that Don't upgrade HTTPS connections is NOT being used

step 3	step 4	step 5	step 6

---

Settings comparison

• No new settings are added as part of CR 114
• The settings Autofill is renamed to Autofill and passwords and which is same as Chrome 114 (asked a clarification in https://bravesoftware.slack.com/archives/CU5UXM3EC/p1684307593162539?thread_ts=1683915585.881759&cid=CU5UXM3EC)
• The new cookies settings is been added in lock icon, logged Remove Block third-party cookies toggle from Cookies and site data popup in lock icon  #30396

Components updater

• No new components are added as part of CR 114
• Components are updated successfully without any error

1.51.114 Chromium: 113.0.5672.92	1.52 Chromium: 114.0.5735.26

Brave startup calls

• Confirmed that only Brave domains are listed in Fiddler Everywhere when the build is launched with a clean profile
• Confirmed no calls to google, gstatic, etc., domains when the build is launched with a clean profile

[kjozwiak]

Labelled as QA/No & release-notes/exclude in favour of #30461 (comment).