Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spacing issue in on exit tab in Clear browsing data modal #30394

Closed
GeetaSarvadnya opened this issue May 17, 2023 · 3 comments · Fixed by brave/brave-core#18521
Closed

Spacing issue in on exit tab in Clear browsing data modal #30394

GeetaSarvadnya opened this issue May 17, 2023 · 3 comments · Fixed by brave/brave-core#18521

Comments

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented May 17, 2023

Description

Found while testing #29600
Spacing issue in on exit tab in Clear browsing data modal

Steps to Reproduce

  1. NA

Actual result:

image

Expected result:

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.53.44 Chromium: 114.0.5735.26 (Official Build) nightly (64-bit)
Revision 7075cbb66f0542ac3e01ddfde6b813e7d61118a5-refs/branch-heads/5735@{#454}
OS Windows 10 Version 21H2 (Build 19044.2965)

Version/Channel Information:

  • Can you reproduce this issue with the current release? No
  • Can you reproduce this issue with the beta channel? No
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @brave/qa-team @emerick @rebron

@GeetaSarvadnya
Copy link
Author

cc: @aguscruiz

@kjozwiak
Copy link
Member

kjozwiak commented May 21, 2023

The above requires 1.52.107 or higher for 1.52.x verification 👍

@MadhaviSeelam
Copy link

Verification PASSED using

Brave | 1.52.108 Chromium: 114.0.5735.26 (Official Build) beta (64-bit)
-- | --
Revision | 7075cbb66f0542ac3e01ddfde6b813e7d61118a5-refs/branch-heads/5735@{#454}
OS | Windows 11 Version 22H2 (Build 22621.1702)

Installed 1.52.108
launched Brave
open brave://settings/clearBrowserData

Confirmed no additional space is shown in between entries in On exit tab

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment