-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Block third-party cookies
toggle from Cookies and site data popup in lock icon
#30396
Comments
I don't think this is right, I think we want to disable the entire menu with |
As per the above, we'll want to have the above fixed before |
Adding |
The above requires |
Verification
|
Brave | 1.52.112 Chromium: 114.0.5735.35 (Official Build) (x86_64) |
---|---|
Revision | 2295354895fa3652ae47b651481831484f16d1ff-refs/branch-heads/5735@{#713} |
OS | macOS Version 13.5 (Build 22G5027e) |
Clean Install
Steps:
- installed
1.52.112
- launched Brave
- loaded
brave.com
- clicked on the lock icon in the URL bar
- confirmed site settings dialog
- clicked on
Cookies
- confirmed
Cookies and site data
dialog popped up
example | example |
---|---|
Upgraded Profile
Steps:
- installed
1.51.114
- launched Brave
- loaded a few sites
- upgrated to
1.52.112
- clicked on the lock icon in the URL bar
- confirmed site settings dialog
- clicked on
Cookies
- confirmed
Cookies and site data
dialog popped up
example | example |
---|---|
Description
Found while testing #29600
Remove
Block third-party cookies
toggle from Cookies and site data popup in lock iconSteps to Reproduce
Actual result:
Expected result:
Keep the
Manage cookies site data
but remove theBlock third-party cookies
toggle from Cookies.Discussion reg the toggle removal https://bravesoftware.slack.com/archives/CU5UXM3EC/p1684304100013889?thread_ts=1683915585.881759&cid=CU5UXM3EC
Reproduces how often:
Easy
Brave version (brave://version info)
Version/Channel Information:
Other Additional Information:
Miscellaneous Information:
cc: @brave/qa-team @rebron @emerick
The text was updated successfully, but these errors were encountered: