Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Block third-party cookies toggle from Cookies and site data popup in lock icon #30396

Closed
GeetaSarvadnya opened this issue May 17, 2023 · 5 comments · Fixed by brave/brave-core#18550

Comments

@GeetaSarvadnya
Copy link

Description

Found while testing #29600
Remove Block third-party cookies toggle from Cookies and site data popup in lock icon

Steps to Reproduce

  1. NA

Actual result:

image

Expected result:

Keep the Manage cookies site data but remove the Block third-party cookies toggle from Cookies.
Discussion reg the toggle removal https://bravesoftware.slack.com/archives/CU5UXM3EC/p1684304100013889?thread_ts=1683915585.881759&cid=CU5UXM3EC

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.53.44 Chromium: 114.0.5735.26 (Official Build) nightly (64-bit)
Revision 7075cbb66f0542ac3e01ddfde6b813e7d61118a5-refs/branch-heads/5735@{#454}
OS Windows 10 Version 21H2 (Build 19044.2965)

Version/Channel Information:

  • Can you reproduce this issue with the current release? No
  • Can you reproduce this issue with the beta channel? No
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @brave/qa-team @rebron @emerick

@bridiver
Copy link
Contributor

I don't think this is right, I think we want to disable the entire menu with kPageInfoCookiesSubpage. Exposing the cookie settings here just causes even more problems beyond what we already have with brave://settings/cookies
cc @pes10k

@kjozwiak
Copy link
Member

As per the above, we'll want to have the above fixed before 1.52.x ships. Hence, labelling the above as release/blocking and added it into the 1.52.x milestone so it doesn't slip through the cracks.

@LaurenWags
Copy link
Member

Adding QA/Blocked until this is uplifted to 1.52.x 👍🏻

@kjozwiak
Copy link
Member

The above requires 1.52.112 or higher for 1.52.x verification 👍 Removing QA/Blocked.

@stephendonner
Copy link

stephendonner commented May 25, 2023

Verification PASSED using

Brave 1.52.112 Chromium: 114.0.5735.35 (Official Build) (x86_64)
Revision 2295354895fa3652ae47b651481831484f16d1ff-refs/branch-heads/5735@{#713}
OS macOS Version 13.5 (Build 22G5027e)

Clean Install

Steps:

  1. installed 1.52.112
  2. launched Brave
  3. loaded brave.com
  4. clicked on the lock icon in the URL bar
  5. confirmed site settings dialog
  6. clicked on Cookies
  7. confirmed Cookies and site data dialog popped up
example example
Screenshot 2023-05-25 at 10 31 46 AM Screenshot 2023-05-25 at 10 32 08 AM

Upgraded Profile

Steps:

  1. installed 1.51.114
  2. launched Brave
  3. loaded a few sites
  4. upgrated to 1.52.112
  5. clicked on the lock icon in the URL bar
  6. confirmed site settings dialog
  7. clicked on Cookies
  8. confirmed Cookies and site data dialog popped up
example example
Screenshot 2023-05-25 at 10 39 19 AM Screenshot 2023-05-25 at 10 39 24 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants