Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make all 4 corners of tip panel rounded on all platforms #30489

Closed
zenparsing opened this issue May 22, 2023 · 6 comments · Fixed by brave/brave-core#18487
Closed

Make all 4 corners of tip panel rounded on all platforms #30489

zenparsing opened this issue May 22, 2023 · 6 comments · Fixed by brave/brave-core#18487

Comments

@zenparsing
Copy link

On MacOS, all four corners of the panel are rendered with the same radius, even when different values are specified for each corner (likely due to an upstream bug). In order to normalize across platforms and avoid issues, we should temporarily make all corners rounded on all desktop platforms.

@LaurenWags
Copy link
Member

@brave/qa-team when testing on Windows, please test this on both Windows 10 and Windows 11. Do not add QA Pass-Win64 label until both platforms are verified, thanks!

@kjozwiak
Copy link
Member

The above requires 1.52.110 or higher for 1.52.x verification 👍

@LaurenWags LaurenWags added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label May 24, 2023
@LaurenWags
Copy link
Member

LaurenWags commented May 24, 2023

Verified with

Brave | 1.52.110 Chromium: 114.0.5735.35 (Official Build) (x86_64)
-- | --
Revision | 2295354895fa3652ae47b651481831484f16d1ff-refs/branch-heads/5735@{#713}
OS | macOS Version 13.4 (Build 22F66)

Confirmed all 4 corners of contribution (tip) banner are rounded for various tip banners.
Confirmed on both Dark and Light themes.

Dark Light
dk 1 lt 1
dk 2 lt 2
dk 3 lt 3
dk 4 lt 4

@LaurenWags LaurenWags added QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels May 24, 2023
@MadhaviSeelam
Copy link

Verification PASSED using

Brave | 1.52.110 Chromium: 114.0.5735.35 (Official Build) (64-bit)
-- | --
Revision | 2295354895fa3652ae47b651481831484f16d1ff-refs/branch-heads/5735@{#713}
OS | Windows 11 Version 22H2 (Build 22621.1702)
  • Confirmed all 4 corners of contribution (tip) banner are rounded for various tip banners.
  • Confirmed on both Dark and Light themes.
Dark Light
image image
image image
image image
image image

@GeetaSarvadnya
Copy link

Verification PASSED on

Brave | 1.52.112 Chromium: 114.0.5735.35 (Official Build) (64-bit)
-- | --
Revision | 2295354895fa3652ae47b651481831484f16d1ff-refs/branch-heads/5735@{#713}
OS | Windows 10 Version 22H2 (Build 19045.2965)
  • Confirmed all 4 corners of contribution (tip) banner are rounded for various tip banners.
  • Confirmed on both Dark and Light themes.
Dark Light
image image
image image
image image
image image

@btlechowski
Copy link

Verification passed on

Brave 1.52.112 Chromium: 114.0.5735.35 (Official Build) (64-bit)
Revision 2295354895fa3652ae47b651481831484f16d1ff-refs/branch-heads/5735@{#713}
OS Ubuntu 18.04 LTS
  • Confirmed all 4 corners of contribution (tip) banner are rounded for various tip banners.
  • Confirmed on both Dark and Light themes.

Light:

image image image image

Dark:

image image image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment