Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade from Chromium 114.0.5735.35 to Chromium 114.0.5735.53 #30588

Closed
emerick opened this issue May 25, 2023 · 6 comments · Fixed by brave/brave-core#18616
Closed

Upgrade from Chromium 114.0.5735.35 to Chromium 114.0.5735.53 #30588

emerick opened this issue May 25, 2023 · 6 comments · Fixed by brave/brave-core#18616

Comments

@emerick
Copy link
Contributor

emerick commented May 25, 2023

Minor Chromium bump

https://chromium.googlesource.com/chromium/src/+log/114.0.5735.35..114.0.5735.53?pretty=fuller&n=10000

QA tests:

  • Check branding items
  • Check for version bump

Additional checks:

  • No specific code changes in Brave (only line number changes in patches)
@kjozwiak
Copy link
Member

The above requires 1.52.113 or higher for 1.52.x verification 👍

@kjozwiak
Copy link
Member

Quick overview of the work remaining re: affected areas due to C114 on the following platforms:

Platforms that only require a spot check due to already completing full check of the affected areas mentioned via #29600 (comment).

Platforms that still need to check/verify the affected areas due to C114 changes as per #29600 (comment).

  • Linux - Still needs to check affected areas

@LaurenWags
Copy link
Member

LaurenWags commented May 26, 2023

Verified with

Brave | 1.52.113 Chromium: 114.0.5735.53 (Official Build) (x86_64)
-- | --
Revision | c499d7ea22c8b2dba278465a5df7b86a8efa4e64-refs/branch-heads/5735@{#970}
OS | macOS Version 13.4 (Build 22F66)
Intel

Verification PASSED on

Brave | 1.52.113 Chromium: 114.0.5735.53 (Official Build) (64-bit)
-- | --
Revision | c499d7ea22c8b2dba278465a5df7b86a8efa4e64-refs/branch-heads/5735@{#970}
OS | Windows 10 Version 22H2 (Build 19045.2965)

image

@btlechowski
Copy link

Verification passed on

Brave 1.52.113 Chromium: 114.0.5735.53 (Official Build) (64-bit)
Revision c499d7ea22c8b2dba278465a5df7b86a8efa4e64-refs/branch-heads/5735@{#970}
OS Ubuntu 18.04 LTS

image

Verify creating a new profile - PASSED
  • Confirmed that user can create new profile
  • Confirmed that user can create multiple profiles
  • Confirmed that user can switch between the multiple profiles
Verify that memory saver feature is still exposed in brave://settings - PASSED
  • Confirmed that Memory Saver is toggled to Off by default under brave://settings/system

image

Verify that Ads notifications continue to look/work as expected - PASSED
  • Confirmed that ads are served when rewards is enabled
  • Confirmed that ad notifications are auto dismissed after 2 mins (160 secs)
  • Confirmed that click on the ad notification opens up the ads landing page
  • Confirmed that users are rewarded for viewing the ads
  • Confirmed that ad notification count and estimated ads earning are show correctly on the Ads panel
image image image
Verify that UI for tabs continues to look as expected - PASSED
  • Confirmed that UI for horizontal tabs works/looks as expected
  • Confirmed that UI for vertical tabs works/looks as expected
  • Confirmed that Tab hover mode options works as expected
  • Confirmed that show tab search settings works as expected

image

Verify that vertical tabs continue to work as expected - PASSED

General testing on Vertical tabs :

  • Confirmed that Use vertical tabs settings is added in Tabs section under brave://settings/appearance
  • Confirmed that tabs orientation changed to vertical when user toggle the Use vertical tabs settings via brave://settings/appearance
  • Verified that sites can be added to vertical tab by clicking on the + New tab or Ctrl+T
  • Right click on any site added in the vertical tab shows the site context menu options
  • Verified that reading list and vertical tabs cab be enabled at the same time
  • Right click on any site and select Add tab to reading list context menu option and ensured site can be added to the reading list
  • Right click on any site and select Add a tab to new group and ensured that the selected site can be added to new tab group
  • Right click on the sites in vertical tab and select Add a tab to new group and then created tab (e.g test which I have created in my testing) group and ensured that sites got added to the tab group test
  • Verified that created tab group can be collapsed/expanded, when the group is expanded sites added in tab groups are shown
  • Right click on any site in vertical tab and select Move tab to another window and ensured that tab is opened in an new window
  • When a tab is moved to the new window, if user try to move another tab to new window, user get option to move the tab to the existing (2nd window) or new window, ensured both options works fine
  • Right click on any site in vertical tab and select Reload context menu option and ensured site gets reloaded/refreshed
  • Right click on any site in vertical tab and select Duplicate context menu option and ensured duplicate tab got added to the tab group
  • Right click on any site in vertical tab and select Pin context menu option and ensured site pinned in the tab group and right clicked on the pinned tab and ensured Unpin option is shown
  • Ensured that pinned site can be unpinned by clicking on the Unpin option
  • Right click on any YT site in vertical tab and select mute context menu option and ensured site is muted and mute option is shown in the URL bar and video is playing in an muted mode.
  • Ensured that YT videos can be unmuted by clicking on the Unmute option
  • Ensured that Close, Close other tabs, Close tabs to the right and Reopen closed tabs works as expected
  • Ensured that the tab Bookmarls all context menu works as expected
  • Ensured that tabs can be drag and drop in an vertical tab
  • Ensured that vertical tab cab be collapsed/expanded, when vertical tabs is expand the tabs with site name and url is shown, when vertical tab cab be collapsed, the site favicons are shown in the vertical tabs

Toggle "Use Vertical tabs" settings ON/OFF

  • Confirmed that Use Vertical tabs toggle ON/OFF works as expected
  • Confirmed that once the Use Vertical tabs toggle is OFF, tabs are shown in horizontal view
  • Confirmed that when tabs are switched between vertical/horizontal, the created tab groups are not lost
  • Confirmed that when tabs are switched between vertical/horizontal, the pinned tabs are not lost

image

Show title bar

  • Confirmed that title bar is shown when the Show title bar toggle is turned ON
  • Confirmed that title bar is NOT shown when the Show title bar toggle is turned OFF

image

Float on mouseover

  • Confirmed that Float on mouseover settings is enabled by default under brave://settings/appearance
  • When vertical tabs are in minimized mode, mouseover on the vertical tabs shows the vertical tabs in floating mode
  • Confirmed that mouseover on the vertical tabs DOESN'T shows the vertical tabs in floating mode when the settings Float on mouseover is unchecked

Tab hover mode

  • Confirmed that Card Tab hover mode settings works as expected on vertical tabs
  • Confirmed that Card with preview Tab hover mode settings works as expected on vertical tabs
  • Confirmed that Tooltip Tab hover mode settings works as expected on vertical tabs

Show tab search button

  • Confirmed that Show tab search button settings works as expected with Vertical tabs enable
  • Confirmed that able to search particular tabs using search tab option
Verify that side panel continues to work as expected - PASSED
  • Confirmed that sidebar is shown by default in the nightly channel
  • Confirmed that Reading list icon is added to the sidebar menu
  • Confirmed that reading list panel is shown when user click on the Reading list icon in the sidebar menu
  • Confirmed that user can add the list of websites to the reading list by clicking on the +Add current tab
  • Confirmed that user can add the list of websites to the reading list by right clicking on the tab and choose the option Add tab to the reading list
  • Confirmed that reading list panel can be hidden by clicking on the Reading list icon in the sidebar menu
  • Confirmed that reading list icon is shown in the URL bar, next to wallet icon
  • Confirmed that user can enable/disable the reading list by clicking on the reading list icon (shown in the URL bar)
  • Confirmed that reading list is shown in all the window types (Normal, PT, TOR and Guest window)
  • Websites can't be added to reading list in Guest, encountered Unable to add a site to reading list in Guest window as Add to current tab option is not getting activated #24930
  • Confirmed that sites can be segregated to Read and Unread list
  • Confirmed that sites can be deleted from the reading list
  • Confirmed that tooltip is shown correctly for each menu item in sidebar
  • Confirmed that click on each sidepanel button Brave Talk, wallet, Bookmarks and Reading list works as expected
image image image image image
Verify brave://settings has all expected pages/functionality - PASSED

Examples:

image image image image image image image image image image image
Verify that downloads dropdown/panel continues to work as expected - PASSED
image image
Verify that the new tab button (+) works as expected - PASSED
  • Confirmed that click new tab button (+) opens up the new tab
  • Confirmed that new tab button (+) works as expected in Horizontal tabs orientation
  • Confirmed that new tab button (+) works as expected in Vertical tabs orientation
  • Confirmed that new tab button (+) works as expected in Normal/PT/TOR and Guest window types
Horizontal new tab button (+) Vertical new tab button (+)
image image
Verify that https upgrades work as expected - PASSED
Case 1: Ensured that connections were upgraded to HTTPS - PASSED

Ensured that connections were upgraded to HTTPS

image

Case 2: Only connect using HTTPS - PASSED
  1. launched/restarted 1.52.x
  2. visited http://upgradable.arthuredelstein.net/ switched HTTPS upgrades to Only connect with HTTPS
  3. ensured that http://upgradable.arthuredelstein.net -> https://upgradable.arthuredelstein.net
  4. opened a Private window and visited http://upgradable.arthuredelstein.net/ and ensured Only connect with HTTPS
  5. ensured that http://upgradable.arthuredelstein.net -> https://upgradable.arthuredelstein.net

Ensured that connections used HTTPS

image image
Case 3: Don't upgrade HTTPS connections - PASSED
  1. launched/restarted 1.52.x
  2. enable #https-by-default via brave://flags
  3. visited http://upgradable.arthuredelstein.net/ and switched HTTPS upgrades to Don't upgrade HTTPS connections in the Shields panel
  4. reloaded http://upgradable.arthuredelstein.net/ and ensured that the website was not being upgraded to HTTPS
  5. opened a Private window and visited http://upgradable.arthuredelstein.net/ and ensured Upgrade connections to HTTPS was selected in the Shields panel
  6. ensured that http://upgradable.arthuredelstein.net -> https://upgradable.arthuredelstein.net

Ensured that Don't upgrade HTTPS connections is NOT being used
image|image

@kjozwiak
Copy link
Member

kjozwiak commented May 26, 2023

Verification PASSED on Pixel 6 running Android 14 using the following build(s):

Brave | 1.52.113 Chromium: 114.0.5735.53 (Official Build) (32-bit)
--- | ---
Revision | c499d7ea22c8b2dba278465a5df7b86a8efa4e64-refs/branch-heads/5735@{#970}
OS | Android 13; Build/UPB2.230407.014; 33; UpsideDownCake
Example Example
Screenshot_20230526-122342 Screenshot_20230526-122348

Verification PASSED on Samsung Galaxy Tab S8 Ultrea running Android 13 using the following build(s):

Brave | 1.52.113 Chromium: 114.0.5735.53 (Official Build) (64-bit)
--- | ---
Revision | c499d7ea22c8b2dba278465a5df7b86a8efa4e64-refs/branch-heads/5735@{#970}
OS | Android 13; Build/TP1A.220624.014; 33; REL
Example Example
Screenshot_20230526_122904_Brave Screenshot_20230526_122928_Brave

@kjozwiak
Copy link
Member

Labelling as QA/No and release-notes/exclude in favour of #30671 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment