Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shields panel is not translated #3064

Closed
btlechowski opened this issue Jan 23, 2019 · 4 comments · Fixed by brave/brave-core#1714
Closed

Shields panel is not translated #3064

btlechowski opened this issue Jan 23, 2019 · 4 comments · Fixed by brave/brave-core#1714

Comments

@btlechowski
Copy link

Follow up from #2831

Steps to Reproduce

  1. Change Brave language to French
  2. Open Brave Shields

Actual result:

Brave shields panel is not translated
image

Expected result:

Brave shields panel is translated to French

Reproduces how often:

always

Brave version (brave://version info)

Brave 0.59.28 Chromium: 72.0.3626.64 (Official Build) beta(64-bit)
Revision eaa9668e80ce5405e7f1902579558ea725c06ca1-refs/branch-heads/3626@{#708}
OS Windows

cc @brave/legacy_qa @bbondy

@kjozwiak
Copy link
Member

@btlechowski do you know if this affects other locales or just French?

@tildelowengrimm tildelowengrimm added the priority/P3 The next thing for us to work on. It'll ride the trains. label Jan 24, 2019
@LaurenWags
Copy link
Member

@kjozwiak I reproduced on other locales (like Germany/German) as well

Brave 0.59.28 Chromium: 72.0.3626.64 (Offizieller Build) beta(64-Bit)
Überarbeitung eaa9668e80ce5405e7f1902579558ea725c06ca1-refs/branch-heads/3626@{#708}
Betriebssystem Mac OS X

@bbondy bbondy added priority/P1 A very extremely bad problem. We might push a hotfix for it. and removed priority/P3 The next thing for us to work on. It'll ride the trains. labels Jan 24, 2019
@btlechowski
Copy link
Author

@kjozwiak reproduced on following locales: Polish, Czech, German, Dutch, Danish, Finnish, Italian, Japanese, Korean, Norwegian, Russian, Spanish.

Sanity checked all above locales for any missing strings.
Found: #3094 #3095

@btlechowski
Copy link
Author

btlechowski commented Feb 20, 2019

Verification passed on

Brave 0.60.44 Chromium: 72.0.3626.109 (Official Build) (64-bit)
Revision fae8db7ab9280fa6704a59980263c804f809ebd5-refs/branch-heads/3626@{#857}
OS Windows 7

Verified languages:
Arabic, Bulgarian, Chinese(Traditional), Croatian, Czech, Danish, Dutch, Finish, French, German, Greek, Hebrew, Hungarian, Italian, Japanese, Korean, Lithuanian, Polish, Portuguese, Russian, Slovak, Slovenian, Spanish, Turkish, Vietnamese

Norwegian not translated. Logged: #3425

image
image

Verified passed with

Brave 0.60.44 Chromium: 72.0.3626.109 (Official Build) (64-bit)
Revision fae8db7ab9280fa6704a59980263c804f809ebd5-refs/branch-heads/3626@{#857}
OS Mac OS X

Verification PASSED on Mint 19.1 x64 VM using the following build:

Brave 0.60.45 Chromium: 72.0.3626.109 (Official Build) (64-bit)
Revision fae8db7ab9280fa6704a59980263c804f809ebd5-refs/branch-heads/3626@{#857}
OS Linux

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants