Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

about:gpu differences between Brave and Chrome #3105

Closed
bbondy opened this issue Jan 25, 2019 · 3 comments · Fixed by brave/brave-core#1451
Closed

about:gpu differences between Brave and Chrome #3105

bbondy opened this issue Jan 25, 2019 · 3 comments · Fixed by brave/brave-core#1451
Labels
priority/P1 A very extremely bad problem. We might push a hotfix for it. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release/blocking release-notes/include
Milestone
0.59.x - Release ...

Comments

@bbondy
Copy link
Member

bbondy commented Jan 25, 2019 •
edited
Loading

I verified this with C72 for both Chrome and Brave.

Actual: Viz Service Display Compositor: Disabled on Brave vs enabled on chrome.
Expected: They should be the same

capture d ecran le 2019-01-25 a 09 24 12

capture d ecran le 2019-01-25 a 09 26 01

Viz Service Display Compositor
Chrome 71: Disabled
Chrome 72: Enabled

Brave 71: Disabled
Brave 72: Disabled
@bbondy bbondy added this to the 1.x Backlog milestone Jan 25, 2019
@bbondy bbondy added the priority/P2 A bad problem. We might uplift this to the next planned release. label Jan 25, 2019
@bbondy bbondy changed the title about:gpu differences between Brave and Chrome on macOS about:gpu differences between Brave and Chrome Jan 25, 2019
@bbondy bbondy added priority/P1 A very extremely bad problem. We might push a hotfix for it. release/blocking and removed priority/P2 A bad problem. We might uplift this to the next planned release. labels Jan 25, 2019
@bbondy bbondy modified the milestones: 1.x Backlog, 0.59.x - Release Jan 25, 2019
This was referenced Jan 25, 2019
Merged
Merged
Merged
Merged
@LaurenWags
Copy link
Member

@bbondy verified the Viz Service Display Compositor setting says Enabled, any other testing required for this one?
screen shot 2019-01-25 at 3 03 41 pm

@bbondy
Copy link
Member Author

bbondy commented Jan 25, 2019

nothing else required. Thanks!

@LaurenWags
Copy link
Member

LaurenWags commented Jan 25, 2019 •
edited by kjozwiak
Loading

Verified passed with

Brave 0.59.30 Chromium: 72.0.3626.71 (Official Build) (64-bit)
Revision f52ccad2a6a3c65fc9e0c591a517ceab1198dac0-refs/branch-heads/3626@{#763}
OS Mac OS X

Verification passed on

Brave 0.59.30 Chromium: 72.0.3626.71 (Official Build) (64-bit)
Revision f52ccad2a6a3c65fc9e0c591a517ceab1198dac0-refs/branch-heads/3626@{#763}
OS Windows 7

image

Verification passed on

Brave 0.59.30 Chromium: 72.0.3626.71 (Official Build) (64-bit)
Revision f52ccad2a6a3c65fc9e0c591a517ceab1198dac0-refs/branch-heads/3626@{#763}
OS Linux

screenshot from 2019-01-28 11-17-52

Verification PASSED on Mint 19.1 x64 VM using the following build:

Brave 0.59.30 Chromium: 72.0.3626.71 (Official Build) (64-bit)
Revision f52ccad2a6a3c65fc9e0c591a517ceab1198dac0-refs/branch-heads/3626@{#763}
OS Linux

brave://gpu from Min 19.1 x64 running on a VM:

screen shot 2019-01-28 at 12 37 08 am

brave://gpu from Min 19.1 x64 running on a psychical machine:

screenshot from 2019-01-28 00-49-04

@petemill petemill mentioned this issue Jan 30, 2019
Closed
@kjozwiak kjozwiak mentioned this issue Jan 31, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority/P1 A very extremely bad problem. We might push a hotfix for it. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release/blocking release-notes/include
Projects
None yet
Milestone
0.59.x - Release (Release Channel)
Development

Successfully merging a pull request may close this issue.

Don't disable Viz Service Display Compositor to match Chrome 72 brave/brave-core
5 participants
@bbondy @kjozwiak @srirambv @LaurenWags @btlechowski