-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync: do not leave zombie devices after sync chain is deleted #3225
Labels
Milestone
Comments
18 tasks
This was referenced Feb 7, 2019
Verification passed on
Used test plan from brave/brave-core#1560. Verification passed on
Verified passed with
|
This was referenced Mar 1, 2019
rebron
changed the title
Sync: do not left zombie devices after chain delete
Sync: do not leave zombie devices after sync chain is deleted
Mar 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Description
When there are two devices in chain and the second device leaves the chain, the first get notified it is the only in chain and does reset without sending DELETE record. Then if connect to that chain later with saved code words or QR, zombie device can be seen.
Steps to Reproduce
View sync code
->View QR code
, do the screenshot of QR codeLeave Sync Chain
Actual result:
You will see two devices in chain: android device and zombie.
Expected result:
You should see only android device.
Reproduces how often:
Easily
Brave version (brave://version info)
0.61.6
Reproducible on current release:
yes, both releases and beta
The text was updated successfully, but these errors were encountered: