-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewards panel is stuck in pre-opt state if wallet creation fails/crashes browser #3416
Labels
Comments
NejcZdovc
added
the
priority/P3
The next thing for us to work on. It'll ride the trains.
label
Feb 26, 2019
closing as dupe of #3440 |
NejcZdovc
added
closed/duplicate
Issue has already been reported
and removed
QA/No
priority/P3
The next thing for us to work on. It'll ride the trains.
labels
Mar 7, 2019
bsclifton
added
closed/duplicate
Issue has already been reported
and removed
closed/duplicate
Issue has already been reported
labels
May 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Description
While testing other fixes. Introduced a situation where if the browser crashes when creating a wallet from panel, the panel will forever be stuck in pre-opt state.
Steps to Reproduce
Dev will need to introduce crash (induce DCHECK failure in
RewardsServiceImpl::OnPanelPublisherInfo
and try to push panel create wallet before crash occurs)Actual result:
Panel is stuck in pre-optin state. Only a profile clear can resolve.
Expected result:
Either attempt to create wallet again or accept created wallet.
Reproduces how often:
Tricky. Would be very difficult to repro on a release build. Would more than likely only occur if there was an OS crash or any other catastrophic failure.
Brave version (brave://version info)
found on 0.63.x
Reproducible on current release:
?
Website problems only:
Additional Information
The text was updated successfully, but these errors were encountered: