Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewards panel is stuck in pre-opt state if wallet creation fails/crashes browser #3416

Closed
jasonrsadler opened this issue Feb 19, 2019 · 1 comment
Labels

Comments

@jasonrsadler
Copy link

jasonrsadler commented Feb 19, 2019

Description

While testing other fixes. Introduced a situation where if the browser crashes when creating a wallet from panel, the panel will forever be stuck in pre-opt state.

Steps to Reproduce

Dev will need to introduce crash (induce DCHECK failure in RewardsServiceImpl::OnPanelPublisherInfo and try to push panel create wallet before crash occurs)

Actual result:

screen shot 2019-02-19 at 12 13 42 pm

Panel is stuck in pre-optin state. Only a profile clear can resolve.

Expected result:

Either attempt to create wallet again or accept created wallet.

Reproduces how often:

Tricky. Would be very difficult to repro on a release build. Would more than likely only occur if there was an OS crash or any other catastrophic failure.

Brave version (brave://version info)

found on 0.63.x

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds?
    ?

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
  • Is the issue reproducible on the latest version of Chrome?

Additional Information

@NejcZdovc NejcZdovc added the priority/P3 The next thing for us to work on. It'll ride the trains. label Feb 26, 2019
@NejcZdovc
Copy link
Contributor

closing as dupe of #3440

@NejcZdovc NejcZdovc added this to the Dupe / Invalid / Not actionable milestone Mar 7, 2019
@NejcZdovc NejcZdovc added closed/duplicate Issue has already been reported and removed QA/No priority/P3 The next thing for us to work on. It'll ride the trains. labels Mar 7, 2019
@rebron rebron removed this from the Dupe / Invalid / Not actionable milestone May 7, 2019
@bsclifton bsclifton added closed/duplicate Issue has already been reported and removed closed/duplicate Issue has already been reported labels May 26, 2019
@NejcZdovc NejcZdovc added this to the Dupe / Invalid / Not actionable milestone Jun 3, 2019
@bbondy bbondy removed this from the Dupe / Invalid / Not actionable milestone May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants