Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

do not add internal pages in NTP top sites #3710

Closed
cezaraugusto opened this issue Mar 13, 2019 · 1 comment · Fixed by brave/brave-core#1932
Closed

do not add internal pages in NTP top sites #3710

cezaraugusto opened this issue Mar 13, 2019 · 1 comment · Fixed by brave/brave-core#1932
Assignees
@cezaraugusto
Labels
feature/new-tab QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/include
Milestone
0.62.x - Release ...

Comments

@cezaraugusto
Copy link
Contributor

cezaraugusto commented Mar 13, 2019 •
edited by bsclifton
Loading

at first run NTP shows https://chrome.google.com/webstore?hl=en as a top site and it should not.

Test Plan

  • Reset your profile
  • Open Brave
  • Open NTP
  • no tiles should show
@cezaraugusto cezaraugusto self-assigned this Mar 13, 2019
@cezaraugusto cezaraugusto changed the title do not log internal pages in NTP top sites do not add internal pages in NTP top sites Mar 13, 2019
@cezaraugusto cezaraugusto mentioned this issue Mar 13, 2019
Merged
@bsclifton bsclifton added this to the 0.64.x - Nightly milestone Mar 13, 2019
@cezaraugusto cezaraugusto mentioned this issue Mar 13, 2019
Merged
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Mar 19, 2019 •
edited by LaurenWags
Loading

Verification passed on

Brave 0.62.32 Chromium: 73.0.3683.75 (Official Build) beta (64-bit)
Revision 909ee014fcea6828f9a610e6716145bc0b3ebf4a-refs/branch-heads/3683@{#803}
OS Windows 10 OS Build 17134.523
  • Verified the STR mentioned in the description
    image

Verification passed on

Brave 0.63.14 Chromium: 73.0.3683.75 (Official Build) dev(64-bit)
Revision 909ee014fcea6828f9a610e6716145bc0b3ebf4a-refs/branch-heads/3683@{#803}
OS Ubuntu 18.04 LTS

Verified the STR mentioned in the description
Logged #3805

Verified passed with

Brave 0.62.33 Chromium: 73.0.3683.75 (Official Build) beta(64-bit)
Revision 909ee014fcea6828f9a610e6716145bc0b3ebf4a-refs/branch-heads/3683@{#803}
OS Mac OS X

Verified the STR mentioned in the description
Encountered #3805

@btlechowski btlechowski mentioned this issue Mar 20, 2019
Closed
@kjozwiak kjozwiak mentioned this issue Apr 3, 2019
Closed
@LaurenWags LaurenWags mentioned this issue Jul 24, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cezaraugusto cezaraugusto

Labels
feature/new-tab QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/include
Projects
None yet
Milestone
0.62.x - Release (Release Channel)
Development

Successfully merging a pull request may close this issue.

do not count urls in NTP top sites not coming from http or https brave/brave-core
6 participants
@cezaraugusto @bsclifton @rebron @LaurenWags @btlechowski @GeetaSarvadnya