Accumulated ads and earnings disappearing after upgrade

[jsecretan]

Description

When upgrading from 0.63.4 to 0.63.8, accumulated ads earnings are reset to 0.

Steps to Reproduce

1. Install 0.63.4
2. Trigger an advertisment
3. Check notifications/earnings in rewards settings
4. Initiate upgrade through about
5. Re-check notifications/earnings

Actual result:

Expected result:

Ad notification count and current earnings should be the same as before the upgrade.

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

0.63.4/0.63.8

Reproducible on current release:

Dev builds

Additional Information

Attaching a before and after ledger state

ledger_state_v0638.txt
ledger_state_v0634.txt

[jsecretan]

Adding confirmations json as well

confirmations-v0634.txt
confirmations-v0638.txt

[242145gh]

i downgraded and still no User ads?! and my bat missing ?

[jsecretan]

Unfortunately, a downgrade will not make the missing ad views appear. However, we are going to bonus dev users for lost views when ad grants with the actual BAT are issued on or around the 5th of the month.

[GeetaSarvadnya]

Verification passed on

Brave	0.63.20 Chromium: 73.0.3683.75 (Official Build) dev (64-bit)
Revision	909ee014fcea6828f9a610e6716145bc0b3ebf4a-refs/branch-heads/3683@{#803}
OS	Windows 10 OS Build 17134.523

• Verified the STR mentioned in the description

Verified passed with

Brave	0.63.30 Chromium: 73.0.3683.75 (Official Build) beta(64-bit)
Revision	909ee014fcea6828f9a610e6716145bc0b3ebf4a-refs/branch-heads/3683@{#803}
OS	Mac OS X

Since 0.63.4 was on Dev channel, I renamed the Dev profile and launched with 0.63.30 on Beta. Verified that Ad earnings were maintained. Additionally, I updated 0.63.4 on Dev channel to the version below and verified that Ad earnings were maintained.

Brave	0.64.30 Chromium: 73.0.3683.75 (Official Build) dev(64-bit)
Revision	909ee014fcea6828f9a610e6716145bc0b3ebf4a-refs/branch-heads/3683@{#803}
OS	Mac OS X

Verfication passed on

Brave	0.63.44 Chromium: 74.0.3729.75 (Official Build) beta(64-bit)
Revision	fdb7915642fef8cf997beac2554709d148e3c187-refs/branch-heads/3729@{#754}
OS	Linux

• Verified upgrading from 0.63.30 to 0.63.44 didn't lose the accumulated ads.