-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature Request: A permanent URL for the inner dashboard page #4100
Comments
cc: @jonathansampson |
Same situation here. I have an extension that allows the NTP override to be "disabled." Since the extension API doesn't provide a mechanism for this, in Chrome it works by redirecting to I think fixing this is as easy as adding an entry here: |
BTW, Chrome 85+ has a new inner URL of |
Bumping this up, Looks like brave://new-tab-page/ goes to the default chrome page and not the dashboard page, so its not the ideal solution as there's still no way to redirect the dashboard inner page using a url. |
Bumping this up. Same issue here with Unsplash Instant. Defaulting to |
Bumping this one. Would like to see: chrome-search://local-ntp/local-ntp.html supported in Brave and properly redirected to the Brave NTP. 👍 |
Description
I'm an author of the Chrome extension "Vimium C". While my extension overrides the default newtab page (to make it configurable on my extension's options page), one user of Vimium C has asked me for re-enable the default dashboard as the new tab page: gdh1995/vimium-c#28 (comment) .
After I searched in the source code of brave-core, I found it only maps the https://github.com/brave/brave-core/blob/master/components/brave_new_tab_ui/brave_new_tab.html to "chrome://newtab/". So the user's request is impossible up to now.
Considering that Chrome has a permanent inner page just looking like the default newtab page: chrome-search://local-ntp/local-ntp.html , I think the brave browser should also assign a URL for the beautiful dashboard page.
Steps to Reproduce
Actual result:
Expected result:
An extension can use a URL (like "brave://inner-newtab") to open the dashboard page, whether the new tab page is overridden / changed or not.
Brave version (brave://version info)
0.62.51 Chromium: 73.0.3683.103 (正式版本) (64 位)
e82a658d8159cabbd4938c1660f9bb00b4a82a23-refs/branch-heads/3683@{#902}
Windows 10 OS Build 17763.379
V8 7.3.492.27
Reproducible on current release:
Website problems only:
The text was updated successfully, but these errors were encountered: