Shield prevents identity verification with webcam when trying to KYC with Uphold

[Jezz1e]

Test plan

See brave/brave-core#2773

Description

I haven't created an Uphold account yet so when I tried clicking "Connect" through the "Your Uphold Wallet" on the Brave Rewards website and sign up from the given link, I couldn't because of Shield. However, when I disable it I'm able to sign up.

1. Log in to https://publishers.basicattentiontoken.org and click on "Connect" from Your Uphold Wallet. (If you are already connected, you can disconnect and try connecting again)
2. Try signing up (not signing in) with Shield enabled on default settings

Actual result:

Shield doesn't allow signing up

Expected result:

Sign up with no issues

Reproduces how often:

Easily

Brave version (brave://version info)

Brave: 0.62.51 Chromium: 73.0.3683.103 (Official Build) (64-bit)
Revision: e82a658d8159cabbd4938c1660f9bb00b4a82a23-refs/branch-heads/3683@{#902}
OS: Windows 10 OS Build 17763.437

Reproducible on current release:

• Does it reproduce on brave-browser dev/beta builds?
  I have not yet tried

Website problems only:

• Does the issue resolve itself when disabling Brave Shields?
  Disabling Shield resolves the issue
• Is the issue reproducible on the latest version of Chrome?
  Not reproducible on latest ver of Chrome

Additional Information

Due note that I did not sign up through the Uphold website itself because I tried signing up from there and I can do it easily even with Shield on. This issue only occurs when signing up through the link given by the "Connect".

This only affects signing up not signing in

[davidtemkin]

Please prioritize this issue -- we should create rules that allow Uphold connect to work with shields on.

Discussed briefly with @diracdeltas and @evq. Sounds like it is possible. The driver is that Uphold Connect is coming soon for Brave Rewards users -- v 0.68.

cc @mandar-brave @alexwykoff @kjozwiak @rebron @bsclifton

[kjozwiak]

Going to bump this to a P2 as it sounds like want this completed by 0.68.x. Also moved it into Next Up under the Shields projects. @rebron please change if you disagree 👍

[diracdeltas]

it worked for me just now with shields on. 0.65.118 Chromium: 75.0.3770.80 (Official Build) (64-bit) MacOS, default shield settings

[mandar-brave]

@diracdeltas did you try the KYC; with netverify coming in to play (Jumio). Back in Jan when @tomlowenthal and I were playing, we were blocking out KYC. Uphold by itself is not a challenge.

The real issue is the KYC part. https://portal.netverify.com/login
Uphold uses their app version of netverify.com to get users KYC'd.

Thanks.

[diracdeltas]

@mandar-brave can you or @tomlowenthal post the repro steps to hit that bug?

[mandar-brave]

@diracdeltas will do; i am trying to see if i can disconnect my ID from my account; i am already KYC'd and Uphold does not show me the verify option. Also assigned issue to Uphold QA to verify if Brave is blocking any of the steps. stay tuned.

[kjozwiak]

I need to KYC my account either way, so I'll go through the process and document any snags/issues that I run into while using the latest nightly with default shield settings.

[kjozwiak]

Some quick results/observations:

• Used 0.68.56 Chromium: 75.0.3770.90 with the default shields settings

Logging into an already existing Uphold Account - PASSED

Going through https://publishers.basicattentiontoken.org and logging into an already created account works without any issues using the default shields settings. I went through 2FA and had no issues logging into Uphold.

Creating a new account through the Publisher Web Portal - PASSED (x2 attempts)

Seems like creating a new Uphold account through https://publishers.basicattentiontoken.org is also working. Once you've created a new Publisher account, clicking on Connect to Uphold will take you to the following:

Once you fill out the above information and click on Sign up & Authorize, you'll be taken back to the Publisher web portal:

Clicking on Go to Uphold will take you back to the Uphold account and you'll need to fill out the remaining information:

I managed to fill out all the information and setup my 2FA without any problems using the default shield settings.

@mandar-brave seems like it's working (at least on my side)

[kjozwiak]

However, I'm running into an issue when attempting to KYC with Uphold. Once I've created an account, I go through the KYC process and select "License" as my identification. I accept all the permission prompts from Brave to let Brave us the web cam and run into the following error every time:

Once the above fails, clicking on Retry takes you back to the main Uphold page and you'll see the following:

The only data that I ended up providing was my address without ID because the above failed but it seems like Uphold accepted the application even though it's missing information and put it under review. I'm basically stuck now until Uphold asks for more information or locks my account due to incorrect/insufficient information. Retrying the KYC process won't work as you're already in a "Pending" state.

@mandar-brave I managed to reproduce the above three times. I think this is a major issue in terms of users being able to KYC without any issues. Has anyone run into the above before?

[diracdeltas]

@kjozwiak thanks for the detailed repro steps; i edited the issue title accordingly

[bsclifton]

Exceptions that we added before (when doing in-product KYC via a modal) can be seen here:
https://github.com/brave/brave-core/pull/898/files

Specifically you can check browser/brave_rewards/add_funds_popup.cc (and the browser tests, in browser/brave_rewards/add_funds_popup_browsertest.cc)

cc: @mandar-brave @NejcZdovc

[diracdeltas]

i have a fix for this; will add tests then open

[LaurenWags]

@brave/legacy_qa when testing this issue, please test on new and upgraded profiles.

[LaurenWags]

I'm still having trouble with this one. @kjozwiak @diracdeltas could one of you take a look to see if you see the same?

At the step where I have to upload the front of my drivers license I am getting the below screen (I have confirmed that I am trying to upload a .png file):

If I go to shields, I see this:

Allowing all device recognition attempts will allow my KYC to proceed. Seems like maybe we need something additional for this issue to be resolved?

[LaurenWags]

Logged #5800 for #4139 (comment) per discussion with @diracdeltas

[LaurenWags]

@mandar-brave looks like I'm getting this error A network communication problem has occurred. Please try again. when the camera access is set to Blocked instead of Ask (note - Ask is the default setting). Is this expected?

[mandar-brave]

I think we can send this to Uphold for fixing in terms of error; but reasonable to expect that this is expected in terms of failure

[LaurenWags]

Verified passed with

Brave	0.69.116 Chromium: 76.0.3809.100 (Official Build) beta (64-bit)
Revision	ed9d447d30203dc5069e540f05079e493fc1c132-refs/branch-heads/3809@{#990}
OS	Mac OS X

• Verified with default shield settings I was able to sign up as a new user and login as an existing KYC'd user. Note - once I went to complete the KYC process I did encounter a fingerprinting issue as described in default shield prevents uploading image for Uphold KYC #5800. Additionally, I found Shield prevents identity verification with webcam when trying to KYC with Uphold #4139 (comment) which has been shared with Uphold.

Verification passed on

Brave	0.69.121 Chromium: 76.0.3809.132 (Official Build) beta (64-bit)
Revision	fd1acc410994a7a68ac25bc77513d443f3130860-refs/branch-heads/3809@{#1035}
OS	Windows 7 Service Pack 1 (Build 7601.24494)

Verified test plan from brave/brave-core#2773

Verification passed on

Brave	0.69.124 Chromium: 76.0.3809.132 (Official Build) (64-bit)
Revision	fd1acc410994a7a68ac25bc77513d443f3130860-refs/branch-heads/3809@{#1035}
OS	Ubuntu 18.04 LTS

Verified test plan from brave/brave-core#2773