Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize callback should exclude 0% publishers #4386

Closed
NejcZdovc opened this issue May 10, 2019 · 1 comment · Fixed by brave/brave-core#2428
Closed

Normalize callback should exclude 0% publishers #4386

NejcZdovc opened this issue May 10, 2019 · 1 comment · Fixed by brave/brave-core#2428

Comments

@NejcZdovc
Copy link
Contributor

Description

When you have publisher in your AC table that are 0% if normalize happens when you are on rewards page you will see them.

Steps to Reproduce

  1. enable rewards
  2. add a lot of publishers to the table so that you will have some publishers that has % 0
  3. open rewards page and make sure that you don't see 0% publishers in AC table
  4. open youtube video and let it run
  5. go back to rewards page
  6. wait there for 20s

Actual result:

AC list is updated and now you will see 0% publishers in the list

Expected result:

0% publishers should never be in the table

Reproduces how often:

100%

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the dev channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@NejcZdovc NejcZdovc added this to the 0.67.x - Nightly milestone May 10, 2019
@NejcZdovc NejcZdovc self-assigned this May 10, 2019
@NejcZdovc NejcZdovc added the priority/P3 The next thing for us to work on. It'll ride the trains. label May 10, 2019
NejcZdovc added a commit to brave/brave-core that referenced this issue May 13, 2019
@LaurenWags
Copy link
Member

LaurenWags commented Jul 10, 2019

Verified passed with

Brave 0.67.106 Chromium: 75.0.3770.100 (Official Build) beta(64-bit)
Revision cd0b15c8b6a4e70c44e27f35c37a4029bad3e3b0-refs/branch-heads/3770@{#1033}
OS Mac OS X

Verification passed on

Brave 0.67.108 Chromium: 75.0.3770.100 (Official Build) beta (64-bit)
Revision cd0b15c8b6a4e70c44e27f35c37a4029bad3e3b0-refs/branch-heads/3770@{#1033}
OS Windows 10 OS Version 1803 (Build 17134.523)

Verification passed on

Brave 0.67.110 Chromium: 75.0.3770.100 (Official Build) beta(64-bit)
Revision cd0b15c8b6a4e70c44e27f35c37a4029bad3e3b0-refs/branch-heads/3770@{#1033}
OS Ubuntu 18.04 LTS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants