Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tweet button to every Tip panel #4393

Closed
mandar-brave opened this issue May 10, 2019 · 5 comments · Fixed by brave/brave-core#2195
Closed

Add Tweet button to every Tip panel #4393

mandar-brave opened this issue May 10, 2019 · 5 comments · Fixed by brave/brave-core#2195

Comments

@mandar-brave
Copy link

mandar-brave commented May 10, 2019

Test Plan

brave/brave-core#2195

Add Tweet button to every single Tip panel as part of the tipping process.
When user has successful tipped and land on the final thank you page, add the Tweet button as an option for user to tweet.
Button launched Twitter page in a new tab.

@emerick @NejcZdovc

@LaurenWags
Copy link
Member

LaurenWags commented Jul 11, 2019

Verified passed with

Brave 0.67.107 Chromium: 75.0.3770.100 (Official Build) beta(64-bit)
Revision cd0b15c8b6a4e70c44e27f35c37a4029bad3e3b0-refs/branch-heads/3770@{#1033}
OS Mac OS X

Verification passed on

Brave 0.67.108 Chromium: 75.0.3770.100 (Official Build) beta (64-bit)
Revision cd0b15c8b6a4e70c44e27f35c37a4029bad3e3b0-refs/branch-heads/3770@{#1033}
OS Windows 10 OS Version 1803 (Build 17134.523)

Verification passed on

Brave 0.67.110 Chromium: 75.0.3770.100 (Official Build) beta(64-bit)
Revision cd0b15c8b6a4e70c44e27f35c37a4029bad3e3b0-refs/branch-heads/3770@{#1033}
OS Ubuntu 18.04 LTS

@binoyxj
Copy link

binoyxj commented Aug 4, 2019

The text included as part of the auto-tweet is actually broken. It's having some gibberish text too.

@LaurenWags
Copy link
Member

@binoyxj You're probably experiencing #5229. there's a duplicate user handle and some extra text along with it.

@binoyxj
Copy link

binoyxj commented Aug 5, 2019

@binoyxj You're probably experiencing #5229. there's a duplicate user handle and some extra text along with it.

Yup! https://imgur.com/a/tlit5tw

@LaurenWags
Copy link
Member

thanks for confirming @binoyxj !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants