Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move PublisherBanner to mojo interface #4613

Closed
NejcZdovc opened this issue May 27, 2019 · 0 comments · Fixed by brave/brave-core#2828
Closed

Move PublisherBanner to mojo interface #4613

NejcZdovc opened this issue May 27, 2019 · 0 comments · Fixed by brave/brave-core#2828
Labels
dev-concern feature/rewards priority/P5 Not scheduled. Don't anticipate work on this any time soon. QA/No release-notes/exclude
Milestone
0.69.x - Release

Comments

@NejcZdovc
Copy link
Contributor

We need to move PublisherBanner in vendor/bat-native-ledger/include/bat/ledger/publisher_info.h into mojo interface.

Example how to do this brave/brave-core#2432
@NejcZdovc NejcZdovc added the priority/P5 Not scheduled. Don't anticipate work on this any time soon. label May 27, 2019
cg505 added a commit to brave/brave-core that referenced this issue Jun 28, 2019
@cg505
move PublisherBanner to mojo type
cafa58a 
Fixes brave/brave-browser#4613.
@cg505 cg505 mentioned this issue Jun 28, 2019
Merged
32 tasks
@cg505 cg505 added this to the 0.69.x - Nightly milestone Jul 3, 2019
@NejcZdovc NejcZdovc changed the title Move publisher banner to mojo interface Move PublisherBanner to mojo interface Jul 4, 2019
cg505 added a commit to brave/brave-core that referenced this issue Jul 6, 2019
@cg505
move PublisherBanner to mojo type
20203b5 
Fixes brave/brave-browser#4613.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dev-concern feature/rewards priority/P5 Not scheduled. Don't anticipate work on this any time soon. QA/No release-notes/exclude
Projects
None yet
Milestone
0.69.x - Release
Development

Successfully merging a pull request may close this issue.

move PublisherBanner to mojo type brave/brave-core
3 participants
@cg505 @rebron @NejcZdovc