-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Social media options being ignored 0.67.x and above until toggled #4743
Milestone
Comments
32 tasks
Verification passed on
Verified steps from the description. Reproduced the issue on 0.67.79 Verification passed on
Verified passed with
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
Recent refactoring creates a new instance of the adblock engine and so it doesn't preserve the tags which were set on startup.
On startup the tags are not applied.
However if you go into settings and manually toggle them it worked.
Steps to Reproduce
Actual result:
Things like Facebook are not loaded
Expected result:
Things like Facebook should be loaded
Reproduces how often:
Always 0.67.x and 0.68.x
Brave version (brave://version info)
Version/Channel Information:
Other Additional Information:
Miscellaneous Information:
The text was updated successfully, but these errors were encountered: