Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

History should always respect wait time when showing Ads for mobile #4800

Closed
tmancey opened this issue Jun 11, 2019 · 0 comments · Fixed by brave/brave-core#2661
Closed

History should always respect wait time when showing Ads for mobile #4800

tmancey opened this issue Jun 11, 2019 · 0 comments · Fixed by brave/brave-core#2661
Assignees
@tmancey
Labels
bug feature/ads priority/P2 A bad problem. We might uplift this to the next planned release. QA/No release-notes/exclude
Milestone
0.68.x - Release

Comments

@tmancey
Copy link
Contributor

tmancey commented Jun 11, 2019 •
edited
Loading

Description

History should always respect wait time when showing Ads for mobile

Steps to Reproduce

  1. View an Ad

Actual result:

Ads are not shown at a consistent rate on mobile based upon ads per hour setting

Expected result:

Ads should be shown at a consistent rate on mobile based upon ads per hour setting

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release? No
  • Can you reproduce this issue with the beta channel? No
  • Can you reproduce this issue with the dev channel? No
  • Can you reproduce this issue with the nightly channel? No

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? No
  • Does the issue resolve itself when disabling Brave Rewards? No
  • Is the issue reproducible on the latest version of Chrome? No

Miscellaneous Information:
@tmancey tmancey added this to the 0.68.x - Nightly milestone Jun 11, 2019
@tmancey tmancey self-assigned this Jun 11, 2019
@tmancey tmancey changed the title Fix mobile support for respecting history when showing Ads History should always respect wait time when showing Ads for mobile Jun 11, 2019
@tmancey tmancey added the priority/P2 A bad problem. We might uplift this to the next planned release. label Jun 11, 2019
@tmancey tmancey mentioned this issue Jun 11, 2019
Merged
29 tasks
@tmancey tmancey added the bug label Jun 11, 2019
tmancey added a commit to brave/brave-core that referenced this issue Jun 11, 2019
@tmancey
Fix history should always respect wait time when showing Ads for mobile
bc14d62 
Fixes brave/brave-browser#4800
This was referenced Aug 2, 2019
Closed
Closed
Closed
@kjozwiak kjozwiak added QA/No and removed QA/Yes labels Aug 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tmancey tmancey

Labels
bug feature/ads priority/P2 A bad problem. We might uplift this to the next planned release. QA/No release-notes/exclude
Projects
None yet
Milestone
0.68.x - Release
Development

Successfully merging a pull request may close this issue.

Fix history should always respect wait time when showing Ads for mobile brave/brave-core
3 participants
@tmancey @kjozwiak @LaurenWags