Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup chrome-common-chrome_content_client_constants.cc.patch #4944

Closed
simonhong opened this issue Jun 16, 2019 · 0 comments · Fixed by brave/brave-core#2714
Closed

Cleanup chrome-common-chrome_content_client_constants.cc.patch #4944

simonhong opened this issue Jun 16, 2019 · 0 comments · Fixed by brave/brave-core#2714
Assignees
@simonhong
Labels
dev-concern QA/No release-notes/exclude
Milestone
0.68.x - Release

Comments

@simonhong
Copy link
Member

F/U brave/brave-core#2342 (review)
@simonhong simonhong added this to the 0.68.x - Nightly milestone Jun 16, 2019
@simonhong simonhong self-assigned this Jun 16, 2019
This was referenced Jun 16, 2019
Merged
Merged
@simonhong simonhong changed the title Use file overriding for chrome-common-chrome_content_client_constants.cc.patch Cleanup chrome-common-chrome_content_client_constants.cc.patch Jun 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simonhong simonhong

Labels
dev-concern QA/No release-notes/exclude
Projects
None yet
Milestone
0.68.x - Release
Development

Successfully merging a pull request may close this issue.

Cleanup chrome_content_client_constants modification brave/brave-core
3 participants
@bsclifton @simonhong and others