Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move MediaEventInfo to mojo interface #5128

Closed
NejcZdovc opened this issue Jul 4, 2019 · 0 comments · Fixed by brave/brave-core#2873
Closed

Move MediaEventInfo to mojo interface #5128

NejcZdovc opened this issue Jul 4, 2019 · 0 comments · Fixed by brave/brave-core#2873
Labels
dev-concern feature/rewards priority/P5 Not scheduled. Don't anticipate work on this any time soon.
Milestone
0.69.x-backup

Comments

@NejcZdovc
Copy link
Contributor

We need to move MediaEventInfo in vendor/bat-native-ledger/include/bat/ledger/media_event_info.h into mojo interface.

Example how to do this brave/brave-core#2432
@NejcZdovc NejcZdovc added feature/rewards priority/P5 Not scheduled. Don't anticipate work on this any time soon. dev-concern labels Jul 4, 2019
@jdkuki jdkuki self-assigned this Jul 5, 2019
jdkuki added a commit to brave/brave-core that referenced this issue Jul 5, 2019
@jdkuki
Refactor MediaEventInfo to Mojo Type
ba7b951 
Resolves brave/brave-browser#5128
@jdkuki jdkuki mentioned this issue Jul 5, 2019
Merged
32 tasks
jdkuki added a commit to brave/brave-core that referenced this issue Jul 10, 2019
@jdkuki
Refactor MediaEventInfo to Mojo Type
3208876 
Resolves brave/brave-browser#5128
NejcZdovc pushed a commit to brave/brave-core that referenced this issue Jul 22, 2019
@jdkuki @NejcZdovc
Refactor MediaEventInfo to Mojo Type
9237dd4 
Resolves brave/brave-browser#5128
@NejcZdovc NejcZdovc added this to the 0.69.x-backup milestone Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dev-concern feature/rewards priority/P5 Not scheduled. Don't anticipate work on this any time soon.
Projects
None yet
Milestone
0.69.x-backup
Development

Successfully merging a pull request may close this issue.

Refactor MediaEventInfo to Mojo Type brave/brave-core
2 participants
@jdkuki @NejcZdovc