Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate brave-core changes from Android Ads #5160

Closed
tmancey opened this issue Jul 6, 2019 · 3 comments · Fixed by brave/brave-core#2947
Closed

Migrate brave-core changes from Android Ads #5160

tmancey opened this issue Jul 6, 2019 · 3 comments · Fixed by brave/brave-core#2947
Assignees
@tmancey
Labels
feature/ads priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Milestone
0.69.x - Release

Comments

@tmancey
Copy link
Contributor

tmancey commented Jul 6, 2019

Migrate brave-core changes from Android Ads
@tmancey tmancey added this to the 0.69.x - Nightly milestone Jul 6, 2019
@tmancey tmancey self-assigned this Jul 6, 2019
@tmancey tmancey mentioned this issue Jul 6, 2019
Closed
32 tasks
@tmancey tmancey added the QA/Yes label Jul 6, 2019
@tmancey tmancey added the priority/P2 A bad problem. We might uplift this to the next planned release. label Jul 10, 2019
This was referenced Jul 17, 2019
Merged
Closed
tmancey added a commit to brave/brave-core that referenced this issue Jul 18, 2019
@tmancey
Migrate brave-core changes from Android Ads
e6f0035 
Fixes brave/brave-browser#5160

* Added id to NotificationInfo data structure
* Refactored debug logging
* Refactored TabUpdated/TabClosed
* Refactored unseen ads to available ads and decoupled frequency capping
* Refactored background helper and fixed linter errors
* Implemented background helper for Android
* Refactored locale helper
* Implemented locale helper for Android
* Implemented notification helper
* Refactored OnMediaPlaying/OnMediaStopped
* Only show ad notifications on mobile if the app is in the foreground
* Bumped Challenge Bypass Ristretto dependencies
* Refactored GenerateGUID to use base::GenerateGUID
* Enabled Brave ads for Android
* Allow reinitialization of the bundle state database if the file was removed from storage
* Refactored check for network connection
* Implemented ChangeLocale
* Stop collecting activity, delivering notifications and sustaining ad interaction when destroying AdsImpl
* Refactored Client to use callbacks
* Implemented notifications state
* Refactored Initialize and RemoveAllHistory to use callbacks
* Implemented close notification
* Implemented My First Ad
* Refactored notifications
* Updated README.md
* General refactoring
This was referenced Aug 22, 2019
Closed
Closed
Closed
@kjozwiak
Copy link
Member

kjozwiak commented Sep 4, 2019

@tmancey the cases outlined under brave/brave-core#2947 are valid for desktop correct? Just double checking before QA starts verifying the issue.

@tmancey
Copy link
Contributor Author

tmancey commented Sep 4, 2019

@tmancey the cases outlined under brave/brave-core#2947 are valid for desktop correct? Just double checking before QA starts verifying the issue.

These tests are for desktop to make sure mobile changes did not break anything

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Sep 5, 2019 •
edited by btlechowski
Loading

Verification passed on

Brave 0.69.123 Chromium: 76.0.3809.132 (Official Build) beta (64-bit)
Revision fd1acc410994a7a68ac25bc77513d443f3130860-refs/branch-heads/3809@{#1035}
OS Windows 10 OS Version 1803 (Build 17134.523)
  • Verified the test plan Migrate brave-core changes from Android Ads brave-core#2947
  • Verified catalog.json, client.json and notifications.json states are removed when ads are switched off
  • Verified catalog.json, client.json and notifications.json states are created when ads are switched off
  • Verified an ad opens in the same tab when duplicate ad arrived
  • Verified tokens are cashed in for the viewed ads

Verified passed with

Brave 0.69.125 Chromium: 76.0.3809.132 (Official Build) (64-bit)
Revision fd1acc410994a7a68ac25bc77513d443f3130860-refs/branch-heads/3809@{#1035}
OS Mac OS X
  • Verified the test plan Migrate brave-core changes from Android Ads brave-core#2947
  • Verified turning ads off and back on showed Ad notifications (had to visit a site for page classification per test plan)
  • Verified default/ads_service is removed when ads are switched off
  • Verified default/ads_service is created when ads are switched on
  • Verified an ad opens in the same tab when duplicate ad arrived
  • Verified tokens are cashed in for the viewed ads

Verification passed on

Brave 0.69.125 Chromium: 76.0.3809.132 (Official Build) (64-bit)
Revision fd1acc410994a7a68ac25bc77513d443f3130860-refs/branch-heads/3809@{#1035}
OS Ubuntu 18.04 LTS
  • Verified the test plan Migrate brave-core changes from Android Ads brave-core#2947
  • Verified turning ads off and back on showed Ad notifications (had to visit a site for page classification per test plan)
  • Verified default/ads_service is removed when ads are switched off
  • Verified default/ads_service is created when ads are switched on
  • Verified an ad opens in the same tab when duplicate ad arrived
  • Verified tokens are cashed in for the viewed ads

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tmancey tmancey

Labels
feature/ads priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Projects
None yet
Milestone
0.69.x - Release
6 participants
@tmancey @kjozwiak @bsclifton @LaurenWags @btlechowski @GeetaSarvadnya