Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-use grouped components instead of having duplicates in Storybook #5180

Open
1 task done
cezaraugusto opened this issue Jul 8, 2019 · 2 comments
Open
1 task done

Re-use grouped components instead of having duplicates in Storybook #5180

cezaraugusto opened this issue Jul 8, 2019 · 2 comments
Labels
dev-concern dev-setup Epic priority/P5 Not scheduled. Don't anticipate work on this any time soon. QA/No release-notes/exclude

Comments

@cezaraugusto
Copy link
Contributor

cezaraugusto commented Jul 8, 2019 •
edited
Loading

After brave/brave-core#2857 we now have feature components and grouped components stored in the same place. We could take advantage of this and re-use components in Storybook and brave-core.

This would likely change some components' API but future-wise this practice would improve productivity and avoid common copy/paste mistakes.

Setting as p5 for now until I can investigate how doable it is and how fast we can move.

Self-assigning for tracking purposes.
@cezaraugusto cezaraugusto added needs-investigation A bug not 100% confirmed/fixed dev-setup priority/P5 Not scheduled. Don't anticipate work on this any time soon. labels Jul 8, 2019
@cezaraugusto cezaraugusto self-assigned this Jul 8, 2019
@petemill
Copy link
Member

petemill commented Jul 9, 2019

@cezaraugusto Do you have an example of what this is referring to?

@cezaraugusto
Copy link
Contributor Author

yes, if you search for "footerInfo.tsx" you will see two components. one for storybook and one set as container. ideally we would have only one

@cezaraugusto cezaraugusto added Epic and removed needs-investigation A bug not 100% confirmed/fixed labels Jan 31, 2020
cezaraugusto added a commit to brave/brave-core that referenced this issue Jan 31, 2020
@cezaraugusto
Re-use NTP container in Storybook
dc8e726 
Address brave/brave-browser#5180

Storybook stores several copies of container components. This
effort eliminates them in favor of reusing a real-world component.

Limitations apply such as lack of dynamic content. State changes
are triggered via Storybook Knobs hopefully making easier for non-technical
people to understand and hack around Brave features.
@cezaraugusto cezaraugusto mentioned this issue Jan 31, 2020
Merged
32 tasks
cezaraugusto added a commit to brave/brave-core that referenced this issue Feb 19, 2020
@cezaraugusto
Re-use NTP container in Storybook
3915d02 
Address brave/brave-browser#5180

Storybook stores several copies of container components. This
effort eliminates them in favor of reusing a real-world component.

Limitations apply such as lack of dynamic content. State changes
are triggered via Storybook Knobs hopefully making easier for non-technical
people to understand and hack around Brave features.
cezaraugusto added a commit to brave/brave-core that referenced this issue Feb 21, 2020
@cezaraugusto
Re-use NTP container in Storybook
76873da 
Address brave/brave-browser#5180

Storybook stores several copies of container components. This
effort eliminates them in favor of reusing a real-world component.

Limitations apply such as lack of dynamic content. State changes
are triggered via Storybook Knobs hopefully making easier for non-technical
people to understand and hack around Brave features.
jonathanKingston pushed a commit to jonathanKingston/brave-core that referenced this issue Mar 11, 2020
@cezaraugusto @jonathanKingston
Re-use NTP container in Storybook
e6fb96d 
Address brave/brave-browser#5180

Storybook stores several copies of container components. This
effort eliminates them in favor of reusing a real-world component.

Limitations apply such as lack of dynamic content. State changes
are triggered via Storybook Knobs hopefully making easier for non-technical
people to understand and hack around Brave features.
@cezaraugusto cezaraugusto mentioned this issue Mar 14, 2020
Closed
32 tasks
cezaraugusto added a commit to brave/brave-core that referenced this issue Mar 16, 2020
@cezaraugusto
Storybook: De-duplicate Shields component
2d4b6d9 
Address brave/brave-browser#5180
@cezaraugusto cezaraugusto removed their assignment May 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dev-concern dev-setup Epic priority/P5 Not scheduled. Don't anticipate work on this any time soon. QA/No release-notes/exclude
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@petemill @cezaraugusto