Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ad matching for ads that are not categorized #5183

Closed
jsecretan opened this issue Jul 8, 2019 · 2 comments · Fixed by brave/brave-core#3158
Closed

Ad matching for ads that are not categorized #5183

jsecretan opened this issue Jul 8, 2019 · 2 comments · Fixed by brave/brave-core#3158
Assignees
@tmancey
Labels
feature/ads priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Milestone
0.69.x - Release

Comments

@jsecretan
Copy link

Description

There are some Brave Ads that we want to be able to serve without having to match against specific categorized content. There are two use cases here:

  1. For our existing content/language models, being able to specify that, if we have nothing in the catalog that fits the content interest, we can show the given ad.
  2. For new markets where we are still developing/tuning language models, being able to enter them more quickly by allowing ads to short circuit the content model.

To do this, we should make the following code changes to how the native libraries activate ads:

  1. In setting up eligible countries, we should be able to mark them with a special flag that indicates they should short circuit the language model.
  2. When it goes to execute content categorization, it should simply inject the "untargeted" category into the list.
  3. To use this where we have valid language models but still want to be able to easily enable these ads, we should also inject "untargeted" into the list when we have found no other matching categories.
@jsecretan jsecretan added enhancement feature/rewards priority/P2 A bad problem. We might uplift this to the next planned release. labels Jul 8, 2019
@tmancey tmancey removed their assignment Jul 17, 2019
@jsecretan jsecretan added priority/P3 The next thing for us to work on. It'll ride the trains. and removed priority/P2 A bad problem. We might uplift this to the next planned release. labels Jul 17, 2019
@jsecretan jsecretan added priority/P2 A bad problem. We might uplift this to the next planned release. and removed priority/P3 The next thing for us to work on. It'll ride the trains. labels Aug 9, 2019
@tmancey tmancey self-assigned this Aug 9, 2019
@tmancey tmancey added this to the 0.70.x - Nightly milestone Aug 9, 2019
@tmancey tmancey mentioned this issue Aug 13, 2019
Merged
32 tasks
tmancey added a commit to brave/brave-core that referenced this issue Aug 13, 2019
@tmancey
Ad matching for ads that are not categorized
b1c84cb 
Fixes brave/brave-browser#5183
@tmancey tmancey mentioned this issue Aug 14, 2019
Closed
@tmancey tmancey added the QA/Yes label Aug 14, 2019
This was referenced Sep 23, 2019
Closed
Closed
Closed
@GeetaSarvadnya GeetaSarvadnya mentioned this issue Sep 26, 2019
Closed
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Sep 27, 2019 •
edited by btlechowski
Loading

Verification is passed on

Brave 0.69.130 Chromium: 77.0.3865.90 (Official Build) (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS Windows 10 OS Version 1803 (Build 17134.1006)

################ Region US ######
Ad triggers from parent category: "technology & computing-software"

image

Ad triggers from parent category: "food & drink-cooking"

image

Ad triggers from parent category: "sports-sports"

image

################ Region Australia ######

Ad triggers from parent category: "pets-pets"

image

################ Region France ######
Ad triggers from parent category: "Technology & computing"
image

################ Region Germany ######
Ad triggers from parent category: "Technology & computing"

image

  • Verified targeted ads for PARENT-CHILD page classifications are served for the US

################ Region US ######
Ad triggers from PARENT-CHILD category: "fashion-jewelry" (https://www.today.com/style/best-costume-jewelry-where-buy-cheap-jewelry-online-t130463)

image

Verified passed with

Brave 0.69.131 Chromium: 77.0.3865.90 (Official Build) (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS macOS Version 10.13.6 (Build 17G5019)
  • Verified Parent and Parent-Child ads. Untargeted ads will be verified with 0.70.x per discussion on slack.
  • Verified targeted ads for Parent-child classification are served for US
    • Ad was triggered from PARENT-CHILD category: fashion-jewelry
[17137:775:1001/152205.027241:INFO:ads_impl.cc(837)] Notification for category fashion-jewelry
[17137:775:1001/152205.033696:INFO:client.cc(563)] Successfully saved client state
[17137:775:1001/152205.034789:INFO:ads_impl.cc(895)] Found 5 out of 5 availables ads for "fashion-jewelry" category
[17137:775:1001/152205.035070:INFO:ads_impl.cc(1047)] Notification shown:
  id: 9b4d6e24-e739-452e-ab96-d73b1ac503ed
  campaign_id: 9cb5b28b-d53a-4c5d-9195-88fb98895e63
  winnerOverTime: fashion-jewelry
  advertiser: Home Chef
  category: fashion-jewelry
  text: Meals anyone can cook & everyone will love at Home Chef
  url: https://www.homechef.com/number-one?utm_source=Affiliate&utm_medium=Brave&voucher=BRAVE80&campaign=f&p5
  uuid: 40e87362-6225-45d1-b662-524feb7e280c
[17137:775:1001/152205.039274:INFO:notifications.cc(246)] Saving notifications state
[17136:775:1001/152205.041860:INFO:confirmations_impl.cc(1037)] Confirm ad:
  id: 9b4d6e24-e739-452e-ab96-d73b1ac503ed
  creative_set_id: 0faeaca3-ec53-4834-9412-dcc0fcf0beae
  advertiser: Home Chef
  category: fashion-jewelry
  text: Meals anyone can cook & everyone will love at Home Chef
  url: https://www.homechef.com/number-one?utm_source=Affiliate&utm_medium=Brave&voucher=BRAVE80&campaign=f&p5
  uuid: 40e87362-6225-45d1-b662-524feb7e280c
  type: view
  • Verified targeted ads for PARENT page classifications are served for the US, UK, IRL
    • US region - Ad was triggered by parent category: technology & computing
[17173:775:1001/153429.536689:INFO:ads_impl.cc(837)] Notification for category technology & computing-software
[17173:775:1001/153429.542606:INFO:client.cc(563)] Successfully saved client state
[17173:775:1001/153429.543775:INFO:ads_impl.cc(872)] Notification not made: No ads found in "technology & computing-software" category, trying again with "technology & computing" category
[17173:775:1001/153429.544839:INFO:ads_impl.cc(895)] Found 8 out of 8 availables ads for "technology & computing" category
[17173:775:1001/153429.545059:INFO:ads_impl.cc(1047)] Notification shown:
  id: f18a0dbe-f181-4a50-83ed-d5b641d7ba46
  campaign_id: eff08b98-29ae-4648-8a14-41fe50d7f96f
  winnerOverTime: technology & computing-software
  advertiser: Nord VPN
  category: technology & computing
  text: Protect your online Identity! Get 70% off now!
  url: https://mozgvya.com/path/lp.php?trvid=10017&trvx=1d35ebd8&var1=21_technology
  uuid: c12102b1-11a8-43a0-b645-2998ddf0ea25
[17173:775:1001/153429.548836:INFO:notifications.cc(246)] Saving notifications state
[17172:775:1001/153429.550589:INFO:confirmations_impl.cc(1037)] Confirm ad:
  id: f18a0dbe-f181-4a50-83ed-d5b641d7ba46
  creative_set_id: e85afde1-333e-4156-a695-a50ae6b25792
  advertiser: Nord VPN
  category: technology & computing
  text: Protect your online Identity! Get 70% off now!
  url: https://mozgvya.com/path/lp.php?trvid=10017&trvx=1d35ebd8&var1=21_technology
  uuid: c12102b1-11a8-43a0-b645-2998ddf0ea25
  type: view
  • UK region - Ad was triggered by parent category: food & drink
[17254:775:1001/153918.360950:INFO:ads_impl.cc(872)] Notification not made: No ads found in "food & drink-cooking" category, trying again with "food & drink" category
[17254:775:1001/153918.361898:INFO:ads_impl.cc(895)] Found 8 out of 8 availables ads for "food & drink" category
[17254:775:1001/153918.362101:INFO:ads_impl.cc(1047)] Notification shown:
  id: 1392ecd7-c429-4ba1-ac31-853324063240
  campaign_id: bf18de12-b1ed-476c-ad19-4e394a95511b
  winnerOverTime: food & drink-cooking
  advertiser: Express VPN
  category: food & drink
  text: Protect your online Identity! Get 3 months free now!
  url: https://mozgvya.com/path/lp.php?trvid=10008&trvx=518abffe&var1=21_food
  uuid: 498491e1-757c-4088-8311-596e06c32f07
[17254:775:1001/153918.366077:INFO:notifications.cc(246)] Saving notifications state
[17253:775:1001/153918.368112:INFO:confirmations_impl.cc(1037)] Confirm ad:
  id: 1392ecd7-c429-4ba1-ac31-853324063240
  creative_set_id: 5186dee6-412d-456c-a51d-1e5384443b48
  advertiser: Express VPN
  category: food & drink
  text: Protect your online Identity! Get 3 months free now!
  url: https://mozgvya.com/path/lp.php?trvid=10008&trvx=518abffe&var1=21_food
  uuid: 498491e1-757c-4088-8311-596e06c32f07
  type: view
  • IRL region - Ad was triggered by parent category: fashion
[17400:775:1001/155142.035044:INFO:ads_impl.cc(837)] Notification for category fashion-fashion
[17400:775:1001/155142.035325:INFO:client.cc(563)] Successfully saved client state
[17400:775:1001/155142.036196:INFO:ads_impl.cc(872)] Notification not made: No ads found in "fashion-fashion" category, trying again with "fashion" category
[17400:775:1001/155142.037142:INFO:ads_impl.cc(895)] Found 3 out of 3 availables ads for "fashion" category
[17400:775:1001/155142.037337:INFO:ads_impl.cc(1047)] Notification shown:
  id: 81c7bce6-d14a-4b1c-9849-b6a4d1b68f0b
  campaign_id: e5b243ec-a59f-4735-b781-b261f28a7d3c
  winnerOverTime: fashion-fashion
  advertiser: The Brave Store
  category: fashion
  text: Stay warm this fall and winter with a Brave beanie
  url: https://store.brave.com/collections/vendors?q=Brave&brave=house
  uuid: 7dd14496-4786-47cb-a9ad-19038f51663b
[17400:775:1001/155142.054349:INFO:notifications.cc(246)] Saving notifications state
[17399:775:1001/155142.057545:INFO:confirmations_impl.cc(1037)] Confirm ad:
  id: 81c7bce6-d14a-4b1c-9849-b6a4d1b68f0b
  creative_set_id: 65dfcd2f-9e41-4770-befb-e6c950721451
  advertiser: The Brave Store
  category: fashion
  text: Stay warm this fall and winter with a Brave beanie
  url: https://store.brave.com/collections/vendors?q=Brave&brave=house
  uuid: 7dd14496-4786-47cb-a9ad-19038f51663b
  type: view

Verification passed on

Brave 0.69.131 Chromium: 77.0.3865.90 (Official Build) (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS Ubuntu 18.04 LTS

  • Verified targeted ads for PARENT page classifications are served for the US, UK, IRL

    • US region - Ad was trig
      image
    • UK region - Ad was triggered by parent category: food & drink
      image
    • IRL region - Ad was triggered by parent category: history
      image

  • Verified targeted ads for Parent-child classification are served for US

    • Ad was triggered from PARENT-CHILD category: fashion-jewelry
      image

@tmancey
Copy link
Contributor

tmancey commented Sep 27, 2019

This is correct as we first check the parent child and if no match we check the parent and when no ads are found for the parent we check for untargeted ads

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tmancey tmancey

Labels
feature/ads priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Projects
None yet
Milestone
0.69.x - Release
Development

Successfully merging a pull request may close this issue.

Ad matching for ads that are not categorized brave/brave-core
5 participants
@jsecretan @tmancey @LaurenWags @btlechowski @GeetaSarvadnya