Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable user namespaces in the Debian package #5502

Closed
fmarier opened this issue Aug 1, 2019 · 4 comments · Fixed by brave/brave-release#10
Closed

Enable user namespaces in the Debian package #5502

fmarier opened this issue Aug 1, 2019 · 4 comments · Fixed by brave/brave-release#10
Assignees
Labels
closed/no-milestone OS/Linux priority/P3 The next thing for us to work on. It'll ride the trains. setup/installer

Comments

@fmarier
Copy link
Member

fmarier commented Aug 1, 2019

Lots of users are having problems (e.g. https://twitter.com/robdavies1978/status/1154709097184411648) installing Brave on Debian because of the extra step of enabling user namespaces.

Maybe we should do it for them by shipping a /etc/sysctl.d/brave.conf file containing:

kernel.unprivileged_userns_clone = 1

and then doing a sysctl -p /etc/sysctl.d/brave.conf in the postinst script.

@fmarier fmarier self-assigned this Aug 1, 2019
@fmarier
Copy link
Member Author

fmarier commented Aug 1, 2019

Perhaps we should do this in brave-keyring to avoid having to patch the Chromium source.

@kjozwiak kjozwiak added priority/P3 The next thing for us to work on. It'll ride the trains. setup/installer labels Aug 2, 2019
fmarier added a commit to fmarier/brave-release that referenced this issue Sep 13, 2019
@fmarier fmarier reopened this Sep 17, 2019
@fmarier
Copy link
Member Author

fmarier commented Sep 18, 2019

Fixed in the brave-keyring 1.5 package (i.e. not tied to a particular brave-browser release).

@fmarier fmarier closed this as completed Sep 18, 2019
@tbergeron
Copy link

tbergeron commented Sep 18, 2019

@fmarier could that new package update have caused this:

[ anon@xps ~  ] sudo apt upgrade
Reading package lists... Done
Building dependency tree
Reading state information... Done
Calculating upgrade... Done
0 upgraded, 0 newly installed, 0 to remove and 0 not upgraded.
1 not fully installed or removed.
After this operation, 0 B of additional disk space will be used.
Do you want to continue? [Y/n] y
Setting up brave-keyring (1.4) ...
OK
sysctl: cannot stat /proc/sys/kernel/unprivileged_userns_clone: No such file or directory
dpkg: error processing package brave-keyring (--configure):
 installed brave-keyring package post-installation script subprocess returned error exit status 255
Errors were encountered while processing:
 brave-keyring
E: Sub-process /usr/bin/dpkg returned an error code (1)

just curious, I cannot figure out how to fix this and am wondering if it's normal? thanks!

@fmarier
Copy link
Member Author

fmarier commented Sep 18, 2019

Yes, we had a problem with version 1.4 of the package. This should be fixed in 1.5 though. Try apt update && apt upgrade.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed/no-milestone OS/Linux priority/P3 The next thing for us to work on. It'll ride the trains. setup/installer
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants