Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default shield prevents uploading image for Uphold KYC #5800

Closed
LaurenWags opened this issue Aug 26, 2019 · 3 comments · Fixed by brave/brave-core#3276
Closed

default shield prevents uploading image for Uphold KYC #5800

LaurenWags opened this issue Aug 26, 2019 · 3 comments · Fixed by brave/brave-core#3276
Assignees
Labels
feature/shields/fingerprint The fingerprinting (aka: "device recognition") protection provided in Shields priority/P1 A very extremely bad problem. We might push a hotfix for it. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude

Comments

@LaurenWags
Copy link
Member

LaurenWags commented Aug 26, 2019

Description

Follow up to #4139

When I go to upload an image to complete KYC on Uphold, I get a message that I'm not uploading a supported file type. However, if I change my default FP setting to allow, then I can proceed.

Steps to Reproduce

  1. Go to uphold.
  2. Create an acct and begin KYC.
  3. When you go to upload an image of your driver's license, you will be told your file type is incorrect.
    Note - when testing this, do complete the entire KYC process (uploading all docs and a selfie, and any other information as needed).

Actual result:

kyc-1

When I go to shields I see this:
kyc-2

kyc-3

Expected result:

KYC should work easily without shield changes for users.

Reproduces how often:

easily

Brave version (brave://version info)

0.69.x

Version/Channel Information:

  • Can you reproduce this issue with the current release? probably
  • Can you reproduce this issue with the beta channel? yes
  • Can you reproduce this issue with the dev channel? yes
  • Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? yes
  • Does the issue resolve itself when disabling Brave Rewards? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Miscellaneous Information:

cc @rebron @mandar-brave @kjozwiak - we probably want this in 0.69.x due to the increased volume of users who would encounter this. I added labels per the originally reported issue. Please adjust if necessary.

Assigning to @diracdeltas per discussion with them.

@LaurenWags LaurenWags added priority/P2 A bad problem. We might uplift this to the next planned release. feature/shields/fingerprint The fingerprinting (aka: "device recognition") protection provided in Shields QA/Yes release-notes/exclude QA/Test-Plan-Specified labels Aug 26, 2019
@mandar-brave mandar-brave added priority/P1 A very extremely bad problem. We might push a hotfix for it. and removed priority/P2 A bad problem. We might uplift this to the next planned release. labels Aug 26, 2019
@rebron rebron added this to the 0.69.x - Beta milestone Aug 27, 2019
@rebron
Copy link
Collaborator

rebron commented Aug 27, 2019

cc: @jumde

@ryanbr
Copy link

ryanbr commented Aug 27, 2019

We need to whitelist netverify.com on uphold.com

@btlechowski
Copy link

btlechowski commented Sep 5, 2019

Verification passed on

Brave 0.69.123 Chromium: 76.0.3809.132 (Official Build) beta (64-bit)
Revision fd1acc410994a7a68ac25bc77513d443f3130860-refs/branch-heads/3809@{#1035}
OS Ubuntu 18.04 LTS

Verified test plan from brave/brave-core#3276
Works on Production.
Fails on Staging. Logged #5891

Verification passed on

Brave 0.69.124 Chromium: 76.0.3809.132 (Official Build) (64-bit)
Revision fd1acc410994a7a68ac25bc77513d443f3130860-refs/branch-heads/3809@{#1035}
OS Windows 10 OS Version 1803 (Build 17134.523)

Verified passed with

Brave 0.69.124 Chromium: 76.0.3809.132 (Official Build) (64-bit)
Revision fd1acc410994a7a68ac25bc77513d443f3130860-refs/branch-heads/3809@{#1035}
OS Mac OS X

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/shields/fingerprint The fingerprinting (aka: "device recognition") protection provided in Shields priority/P1 A very extremely bad problem. We might push a hotfix for it. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants