Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

P3A for android #6176

Closed
iefremov opened this issue Sep 26, 2019 · 4 comments · Fixed by brave/brave-core#7016
Closed

P3A for android #6176

iefremov opened this issue Sep 26, 2019 · 4 comments · Fixed by brave/brave-core#7016
Assignees
Labels
features/P3A OS/Android Fixes related to Android browser functionality QA/No release-notes/exclude

Comments

@iefremov
Copy link
Contributor

To launch P3A on android we have to properly inform users about this feature.
Until then, P3A service is disabled in the code for android (see BraveBrowserProcessImpl::brave_p3a_service() usages.

@davidtemkin
Copy link

Added @anthonypkeane to drive mobile UX for notification and onboarding for existing and new users -- should parallel desktop, but will have to be custom-designed.

@bsclifton
Copy link
Member

Let's use this issue to capture the Android specific work needed to get P3A working on Android. #6688 captures the UI changes needed

@srirambv
Copy link
Contributor

@AlexeyBarabash any reason why the issue is marked as QA/No? Shouldn't we test the changes for P3A? The associated PR has a proper test plan mentioned in it

@AlexeyBarabash
Copy link
Contributor

at that time it required modified apk, which would hard to provide to QA team, and also the task wasn't complete without UI part, so it was marked QA/No

With new changes at #12723 it requires a new test plan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
features/P3A OS/Android Fixes related to Android browser functionality QA/No release-notes/exclude
Projects
None yet
Development

Successfully merging a pull request may close this issue.

10 participants