Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brave Ads with the same URL as an open tab do not bring focus to the already opened tab instead opening a new tab #6186

Closed
GeetaSarvadnya opened this issue Sep 26, 2019 · 2 comments
Assignees
Labels

Comments

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Sep 26, 2019

Description

Found while testing #5183
Ads with the same URL as an open tab doesn't bring focus to the already opened tab instead open a new tab

Steps to Reproduce

  1. Open brave 0.69.129
  2. Enable rewards
  3. Set 5 ads per hour
  4. View an ad (I have received https://www.expressvpn.com/vpn-server/us-vpn/buy ad)
  5. View 2nd ad
  6. I have received same ad as in step 4
  7. View 2nd ad opened a new tab instead of focusing on the already opened ad tab

Attached profile for further investigation
https://drive.google.com/open?id=1egDl6G1nGHeo9UgPSKVdtPitVnaEx-8c

Actual result:

Ads with the same URL as an open tab doesn't bring focus to the already opened tab instead open a new tab

Ad with same URL opened in new tab

Expected result:

Ads with the same URL as an open tab, bring focus to the already opened tab and do not open a new tab

Reproduces how often:

Always

Brave version (brave://version info)

Brave 0.69.129 Chromium: 77.0.3865.90 (Official Build) (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS Windows 10 OS Version 1803 (Build 17134.1006)

Version/Channel Information:

  • Can you reproduce this issue with the current release? Not sure
  • Can you reproduce this issue with the beta channel? Not sure
  • Can you reproduce this issue with the dev channel? Not sure
  • Can you reproduce this issue with the nightly channel? Not sure

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @brave/legacy_qa @tmancey @jsecretan

I have viewed both ads and stayed on ads page for more than 10secs even then landed confirmation is not recorded could be due to #4026 . click and view confirmation types are recorded in confirmation.json file

image

@tmancey
Copy link
Contributor

tmancey commented Sep 26, 2019

@GeetaSarvadnya @anthonypkeane Chromium has not implemented functionality to allow this, so only desktop has this functionality at this time

@jsecretan jsecretan added the priority/P5 Not scheduled. Don't anticipate work on this any time soon. label Nov 21, 2019
@tmancey tmancey changed the title Ads with the same URL as an open tab doesn't bring focus to the already opened tab instead open a new tab Brave Ads with the same URL as an open tab do not bring focus to the already opened tab instead opening a new tab Jan 20, 2020
@tmancey tmancey removed QA/Test-Plan-Specified QA/Yes priority/P5 Not scheduled. Don't anticipate work on this any time soon. labels Jan 20, 2020
@tmancey tmancey self-assigned this Feb 23, 2020
@tmancey tmancey added the QA/Yes label Feb 23, 2020
@tmancey
Copy link
Contributor

tmancey commented Feb 23, 2020

@GeetaSarvadnya Resolved with #5195, can you please retest

@tmancey tmancey closed this as completed Feb 23, 2020
@tmancey tmancey added the closed/duplicate Issue has already been reported label Feb 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

No branches or pull requests

3 participants