Extension pages are half translated when browser and extension are on different language

[srirambv]

Description

Reported by @SergeyZhukovsky.
Extension pages are half translated when browser and extension are on different language

Steps to Reproduce

Scenario 1:

1. Set browser language to English and add Russian to the list of browser languages
2. Enable crypto wallet
3. Extension page has mixed translations

Scenario 2:

1. Set browser language to English and add Russian to the list of browser languages
2. Add an extension like MM and set extension language to Russian
3. Extension page has mixed translations

Actual result:

Expected result:

All text should be translated

Reproduces how often:

Easy

Brave version (brave://version info)

Version/Channel Information:

• Can you reproduce this issue with the current release? Yes
• Can you reproduce this issue with the beta channel? Yes
• Can you reproduce this issue with the dev channel? Yes
• Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields? N/A
• Does the issue resolve itself when disabling Brave Rewards? N/A
• Is the issue reproducible on the latest version of Chrome? Yes

Miscellaneous Information:

[kjozwiak]

@bbondy should we move this into https://github.com/brave/brave-browser/milestone/55 as we're going to need a new build for #5698 and possibly #5106?

[kjozwiak]

@ryanml @bbondy looks like I can still reproduce this using https://github.com/brave/ethereum-remote-client/releases/tag/0.1.15 on both Windows 10 x64 & macOS 10.14.6 x64. Examples:

macOS 10.14.6 x64 example:

Windows 10 x64 example:

@srirambv can you check Linux and see if you can reproduce on your end with https://github.com/brave/ethereum-remote-client/releases/tag/0.1.15?

[srirambv]

Reproduced on Linux with 0.1.15

[bbondy]

With regards to newLocalWalletSubText I just cleared out the english strings on each language and did an order to get the string picked up for translation. Once that's done in a few days I can pull the translations and it'll be included in the next extension update.

[bbondy]

@srirambv can you check again?

[srirambv]

This still happens on current component and the rebased component

[bbondy]

Closing as dupe of #7791