Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crypto Wallet dark theme issues #6381

Closed
srirambv opened this issue Oct 9, 2019 · 4 comments · Fixed by brave/ethereum-remote-client#109
Closed

Crypto Wallet dark theme issues #6381

srirambv opened this issue Oct 9, 2019 · 4 comments · Fixed by brave/ethereum-remote-client#109

Comments

@srirambv
Copy link
Contributor

srirambv commented Oct 9, 2019

Description

Crypto wallet on dark theme has a lot of visual theming problems

Steps to Reproduce

  1. Enable crypto wallet
  2. Replace component with 1.0.10 files
  3. Use crypto wallet on dark theme

Actual result:

Brave rewards hyperlink isn't visible on dark theme disclaimer modal
image
Ledger and Trezor icons are not clearly visible on dark mode
image
Same on connect hardware window as well
image
Reset wallet button isn't distinguishable on dark mode
image
Clear Privacy Data and Reveal Seed words are not clearly shown as warn buttons on dark mode
image
Learn more arrow is not visible on dark mode on connect hardware screen
image
Transaction fee selection isn't clear on dark theme
image
Advanced options in transaction isn't visible on dark theme
image
Transaction details not visible on dark theme
image
Transaction processing text is not visible on dark theme
image
Recipient address invalid message is not readable on dark theme
image

Expected result:

All the above should be resolved

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 0.69.132 Chromium: 77.0.3865.90 (Official Build) (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS Linux

Crypto Wallet component 1.0.10

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the dev channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Does the issue resolve itself when disabling Brave Rewards? N/A
  • Is the issue reproducible on the latest version of Chrome? N/A

Miscellaneous Information:

cc: @bbondy @ryanml @jamesmudgett

@srirambv
Copy link
Contributor Author

srirambv commented Feb 3, 2020

Verification passed on

Brave 1.5.73 Chromium: 80.0.3987.66 (Official Build) nightly (64-bit)
Revision 56ea77d65c47ecbb1180b99f860d85b51117864a-refs/branch-heads/3987@{#662}
OS Linux
Component 0.1.37
  • Welcome Screen disclaimer
    image
  • Welcome Screen
    image
  • Create Local wallet
    image
  • Restore wallet
    image
  • Secret Backup Phrase
    image
  • Confirm Secret Backup Phrase
    image
    image
  • Secret Backup phrase verification failed due to Confirm secret phrase doesn't work #8017
  • Connect Hardware
    image
    image
  • Import tab
    image
  • Import JSON Fail
    image
  • Import private key fail
    image
  • Network List
    image.
  • Account Details
    image
  • Deposit Popup
    image
  • Add recipent with incorrect address
    image
  • Add recipent with correct address
    image
  • Connect request popup
    image
  • Add Token popup
    image
  • Custom token with error message
    image
  • Token list
    image
  • Add token
    image-Hide Token context menu
    image
  • Send transaction
    image
  • Customize gas fee via edit transaction
    image
  • General settings
    image
  • Connection settings
    image
  • Advance Settings
    image
    image
    -Security and privacy settings
    image
  • Welcome back login page
    image

@srirambv
Copy link
Contributor Author

srirambv commented Feb 3, 2020

Dark theme related follow up issue #8018

@srirambv
Copy link
Contributor Author

Verification passed on

Brave 1.6.14 Chromium: 80.0.3987.87 (Official Build) nightly (64-bit)
Revision 449cb163497b70dbf98d389f54e38e85d4c59b43-refs/branch-heads/3987@{#801}
OS Windows 10 OS Version 1803 (Build 17134.523)
Component 0.1.42

Screenshot (4)
Screenshot (5)
Screenshot (6)
Screenshot (7)
Screenshot (8)
Screenshot (9)
Screenshot (10)
Screenshot (11)
Screenshot (12)
Screenshot (13)
Screenshot (14)
Screenshot (15)
Screenshot (16)
Screenshot (17)
Screenshot (18)
Screenshot (19)
Screenshot (20)
Screenshot (22)
Screenshot (23)
Screenshot (24)
Screenshot (25)
Screenshot (26)
Screenshot (27)
Screenshot (28)
Screenshot (30)
Screenshot (31)
Screenshot (32)
Screenshot (33)

@srirambv
Copy link
Contributor Author

Verification passed on

Brave 1.6.14 Chromium: 80.0.3987.87 (Official Build) nightly (64-bit)
Revision 449cb163497b70dbf98d389f54e38e85d4c59b43-refs/branch-heads/3987@{#801}
OS macOS Version 10.15.1 (Build 19B88)
Component 0.1.42

Screen Shot 2020-02-11 at 3 58 42 PM

Screen Shot 2020-02-11 at 3 58 46 PM

Screen Shot 2020-02-11 at 3 58 52 PM

Screen Shot 2020-02-11 at 3 59 08 PM

Screen Shot 2020-02-11 at 4 00 41 PM

Screen Shot 2020-02-11 at 4 00 46 PM

Screen Shot 2020-02-11 at 4 00 58 PM

Screen Shot 2020-02-11 at 4 01 03 PM

Screen Shot 2020-02-11 at 4 01 14 PM

Screen Shot 2020-02-11 at 4 01 17 PM

Screen Shot 2020-02-11 at 4 01 23 PM

Screen Shot 2020-02-11 at 4 01 29 PM

Screen Shot 2020-02-11 at 4 01 40 PM

Screen Shot 2020-02-11 at 4 01 44 PM

Screen Shot 2020-02-11 at 4 01 46 PM

Screen Shot 2020-02-11 at 4 01 48 PM

Screen Shot 2020-02-11 at 4 01 51 PM

Screen Shot 2020-02-11 at 4 01 53 PM

Screen Shot 2020-02-11 at 4 02 27 PM

Screen Shot 2020-02-11 at 4 02 40 PM

Screen Shot 2020-02-11 at 4 12 24 PM

Screen Shot 2020-02-11 at 4 12 47 PM

Screen Shot 2020-02-11 at 4 13 10 PM

Screen Shot 2020-02-11 at 4 13 21 PM

Screen Shot 2020-02-11 at 4 13 31 PM

Screen Shot 2020-02-11 at 4 13 37 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants