-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Crypto Wallet dark theme issues #6381
Closed
Labels
feature/ethereum-remote-client
feature/themes
priority/P3
The next thing for us to work on. It'll ride the trains.
QA Pass-Linux
QA Pass-macOS
QA Pass-Win64
QA/Yes
release-notes/include
Milestone
Comments
srirambv
added
QA/Yes
release-notes/exclude
feature/web3/wallet
Integrating Ethereum+ wallet support
feature/themes
labels
Oct 9, 2019
bbondy
added
the
priority/P3
The next thing for us to work on. It'll ride the trains.
label
Dec 20, 2019
This was referenced Feb 3, 2020
Verification passed on
|
Dark theme related follow up issue #8018 |
Verification passed on
|
Verification passed on
|
srirambv
added
QA Pass-macOS
release-notes/include
and removed
release-notes/exclude
labels
Feb 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
feature/ethereum-remote-client
feature/themes
priority/P3
The next thing for us to work on. It'll ride the trains.
QA Pass-Linux
QA Pass-macOS
QA Pass-Win64
QA/Yes
release-notes/include
Description
Crypto wallet on dark theme has a lot of visual theming problems
Steps to Reproduce
Actual result:
Brave rewards
hyperlink isn't visible on dark theme disclaimer modalLedger and Trezor icons are not clearly visible on dark mode
Same on connect hardware window as well
Reset wallet button isn't distinguishable on dark mode
Clear Privacy Data
andReveal Seed words
are not clearly shown as warn buttons on dark modeLearn more arrow is not visible on dark mode on connect hardware screen
Transaction fee selection isn't clear on dark theme
Advanced options in transaction isn't visible on dark theme
Transaction details not visible on dark theme
Transaction processing text is not visible on dark theme
Recipient address invalid message is not readable on dark theme
Expected result:
All the above should be resolved
Reproduces how often:
Easy
Brave version (brave://version info)
Crypto Wallet component
1.0.10
Version/Channel Information:
Other Additional Information:
Miscellaneous Information:
cc: @bbondy @ryanml @jamesmudgett
The text was updated successfully, but these errors were encountered: