-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hover card shows chrome:// on brave:// pages (C78) #6385
Labels
Milestone
Comments
bsclifton
changed the title
Hover card shows chrome:// on brave:// pages
Hover card shows chrome:// on brave:// pages (C78)
Oct 9, 2019
32 tasks
32 tasks
mkarolin
added a commit
to brave/brave-core
that referenced
this issue
Oct 17, 2019
Fixes brave/brave-browser#6385 Replaces chrome:// scheme with brave:// in the hover card text. Added a browser test to test the same. Also, organized brave_browser_tests sources alphabetically in test/BUILD.gn.
This was referenced Oct 17, 2019
Verified passed with
Verification passed on
Verification passed on
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Description
With Chromium 78, hover cards are enabled by default. When you move the mouse over a tab, it shows a bubble which has the title and some text.
When viewing brave:// pages, it'll show
chrome://
in the hover card.Related: #1973 and #3545
Steps to Reproduce
Actual result:
Expected result:
URL shown should be
brave://settings
Reproduces how often:
100%
The text was updated successfully, but these errors were encountered: