Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incognito branding is used for some English locales #6564

Closed
btlechowski opened this issue Oct 21, 2019 · 4 comments
Closed

Incognito branding is used for some English locales #6564

btlechowski opened this issue Oct 21, 2019 · 4 comments
Labels
closed/duplicate Issue has already been reported

Comments

@btlechowski
Copy link

btlechowski commented Oct 21, 2019

Incognito Window branding instead of Private Window is used.

Steps to Reproduce

  1. Set locale to en_GB/en_AU/en_NZ
  2. Run Brave
  3. Open Private Window

Actual result:

Incognito Window branding is used in Hamburger Menu and in Private Window
image

Expected result:

Private Window branding is used in Hamburger Menu and in Private Window

Reproduces how often:

Always

Brave version (brave://version info)

Brave 0.70.119 Chromium: 78.0.3904.50 (Official Build) (64-bit)
Revision 2accdc52c79976e264cd2694df6db31d1fccd8e8-refs/branch-heads/3904@{#658}
OS Ubuntu 18.04 LTS

cc @brave/legacy_qa @rebron

@btlechowski btlechowski changed the title Incognito is used for some English locales Incognito branding is used for some English locales Oct 21, 2019
@srirambv
Copy link
Contributor

Dupe of #738 (comment)

@btlechowski
Copy link
Author

This is not a dupe. #738 is Linux only based on #738 (comment) and this issue reproduces on Windows

Reproduced on Windows for English(New Zealand) locale

Brave 0.70.119 Chromium: 78.0.3904.50 (Official Build) (64-bit)
Revision 2accdc52c79976e264cd2694df6db31d1fccd8e8-refs/branch-heads/3904@{#658}
OS Windows 7 Service Pack 1 (Build 7601.24530)

image

@btlechowski
Copy link
Author

Some English locales are not affected. For example en_US is fine:

image

Brave 0.70.119 Chromium: 78.0.3904.50 (Official Build) (64-bit)
Revision 2accdc52c79976e264cd2694df6db31d1fccd8e8-refs/branch-heads/3904@{#658}
OS Ubuntu 18.04 LTS

@btlechowski
Copy link
Author

Dupe of #2147

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed/duplicate Issue has already been reported
Projects
None yet
Development

No branches or pull requests

2 participants