Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade from Chromium 78.0.3904.108 to Chromium 79.0.3945.56 #6588

Closed
mkarolin opened this issue Oct 23, 2019 · 2 comments · Fixed by #7140 or brave/brave-core#4091
Closed

Upgrade from Chromium 78.0.3904.108 to Chromium 79.0.3945.56 #6588

mkarolin opened this issue Oct 23, 2019 · 2 comments · Fixed by #7140 or brave/brave-core#4091

Comments

@mkarolin
Copy link
Contributor

mkarolin commented Oct 23, 2019

QA tests:

This is a major Chromium version bump, please do full passes.

Affected areas:

  • Avatar button and menu
  • Omnibox colors when theme changes
  • Bookmark button
  • Location bar focus ring, corner radius
  • Ad notifications shouldn't have Settings button on Linux and Mac
@mkarolin mkarolin self-assigned this Oct 23, 2019
@mkarolin mkarolin changed the title Upgrade from Chromium 78.0.3904.70 to Chromium 79.0.3941.4 Upgrade from Chromium 78.0.3904.70 to Chromium 79.0.3945.8 Oct 23, 2019
@mkarolin mkarolin changed the title Upgrade from Chromium 78.0.3904.70 to Chromium 79.0.3945.8 Upgrade from Chromium 78.0.3904.70 to Chromium 79.0.3945.16 Oct 30, 2019
@mkarolin mkarolin changed the title Upgrade from Chromium 78.0.3904.70 to Chromium 79.0.3945.16 Upgrade from Chromium 78.0.3904.97 to Chromium 79.0.3945.29 Nov 8, 2019
@mkarolin mkarolin changed the title Upgrade from Chromium 78.0.3904.97 to Chromium 79.0.3945.29 Upgrade from Chromium 78.0.3904.97 to Chromium 79.0.3945.36 Nov 14, 2019
@mkarolin mkarolin changed the title Upgrade from Chromium 78.0.3904.97 to Chromium 79.0.3945.36 Upgrade from Chromium 78.0.3904.108 to Chromium 79.0.3945.45 Nov 20, 2019
@mkarolin mkarolin changed the title Upgrade from Chromium 78.0.3904.108 to Chromium 79.0.3945.45 Upgrade from Chromium 78.0.3904.108 to Chromium 79.0.3945.56 Nov 27, 2019
@bsclifton bsclifton modified the milestones: 1.3.x - Dev, 1.1.x - Release Dec 4, 2019
@LaurenWags
Copy link
Member

LaurenWags commented Dec 5, 2019

Verified passed with

Brave 1.1.18 Chromium: 79.0.3945.56 (Official Build) (64-bit)
Revision 73cc6bf591f792b99f8fc7cdfb8addedbd084bf8-refs/branch-heads/3945@{#788}
OS macOS Version 10.13.6 (Build 17G5019)

Screen Shot 2019-12-05 at 12 10 11 PM

Verification passed on

Brave 1.1.18 Chromium: 79.0.3945.56 (Official Build) (64-bit)
Revision 73cc6bf591f792b99f8fc7cdfb8addedbd084bf8-refs/branch-heads/3945@{#788}
OS Windows 10 OS Version 1803 (Build 17134.1006)

image

Verification passed on

Brave 1.1.18 Chromium: 79.0.3945.56 (Official Build) (64-bit)
Revision 73cc6bf591f792b99f8fc7cdfb8addedbd084bf8-refs/branch-heads/3945@{#788}
OS Ubuntu 18.04 LTS

image

@LaurenWags
Copy link
Member

Removed release-notes/include as this was superseded by #7213

@bsclifton bsclifton added the Chromium/upgrade major Major version bump. (ex: Chromium 88 to 89) label Apr 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment