-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
'Relaunch' button re-toggles 'Push Messaging' feature before relaunching #6633
Labels
bug
feature/settings
priority/P3
The next thing for us to work on. It'll ride the trains.
QA Pass-Linux
QA Pass-macOS
QA Pass-Win64
QA/Test-Plan-Specified
QA/Yes
release-notes/include
workaround-available
Milestone
Comments
Awesome GIFS. 👏 |
@jumde could you take a look at this? |
Thanks for the report @LesterCovax, investigating this. |
rebron
added
the
priority/P3
The next thing for us to work on. It'll ride the trains.
label
Nov 15, 2019
32 tasks
Verification passed on
Verified test plan from brave/brave-core#4042 Verification PASSED on
Verification passed on
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
feature/settings
priority/P3
The next thing for us to work on. It'll ride the trains.
QA Pass-Linux
QA Pass-macOS
QA Pass-Win64
QA/Test-Plan-Specified
QA/Yes
release-notes/include
workaround-available
Test plan
See brave/brave-core#4042
Description
After enabling or disabling
Use Google Services for Push Messaging
, clicking theRelaunch
button prompt toggles the setting back to its original state before relaunching the browser. After the browser restarts, the setting is in its original state. Runningchrome://restart
in a separate tab after toggling the setting circumvents the issue.Steps to Reproduce
chrome://settings/privacy
Use Google Services for Push Messaging
Relaunch
Actual result:
The setting is visibly toggled back to its original state when
Relaunch
is clicked, followed by the browser restarting.Toggling on...
Toggling off...
Expected result:
The setting should maintain its current state when
Relaunch
is clicked.The Dream...
Reproduces how often:
Easily reproduced
Brave version (brave://version info)
Version/Channel Information:
The setting is not available in release/beta channels currently and I don't have nightly installed.
Other Additional Information:
Miscellaneous Information:
😶
The text was updated successfully, but these errors were encountered: