Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pushing strings to Transifex #6907

Closed
mkarolin opened this issue Nov 13, 2019 · 0 comments · Fixed by #6909 or brave/brave-core#3990
Closed

Fix pushing strings to Transifex #6907

mkarolin opened this issue Nov 13, 2019 · 0 comments · Fixed by #6909 or brave/brave-core#3990
Assignees
@mkarolin
Labels
dev-concern QA/No release-notes/exclude
Milestone
1.3.x - Release

Comments

@mkarolin
Copy link
Contributor

Pushing strings to Transifex is currently broken on master.

The script expects that if a .grd file is added for tracking then all of its .grdp parts are added for tracking as well. This is currently not so for component_strings.grd. We need to add all of the missing .grdp parts.
@mkarolin mkarolin self-assigned this Nov 13, 2019
mkarolin added a commit to brave/brave-core that referenced this issue Nov 13, 2019
@mkarolin
Updated grdp exclusions in transifex.py.
63ff895 
Fixes brave/brave-browser#6907

There is no need to exclude os_settings_strings.grdp and
xr_consent_ui_strings.grdp.

media_router_resources.grdp has been removed upstream.

Chromium change:

https://chromium.googlesource.com/chromium/src/+/edcf55b10dfe41c3ffa18bfbca8f07e62532ef74

commit edcf55b10dfe41c3ffa18bfbca8f07e62532ef74
Author: Takumi Fujimoto <takumif@chromium.org>
Date:   Tue Jul 9 16:36:20 2019 +0000

    Delete Media Router WebUI dialog resource files

    Delete JS/HTML/CSS files for chrome://media-router and its tests.

    We do not remove files related to chrome://media-router-internals
    because that is still in use.

    Bug: 900246
mkarolin added a commit to brave/brave-core that referenced this issue Nov 13, 2019
@mkarolin
Added missing .grdp files.
9165e37 
Fixes brave/brave-browser#6907
mkarolin added a commit that referenced this issue Nov 13, 2019
@mkarolin
Added tracking of missing .grdp files to scripts.
3c5a247 
Fixes #6907
mkarolin added a commit that referenced this issue Nov 13, 2019
@mkarolin
Added tracking of missing .grdp files to scripts.
0f01de0 
Fixes #6907
mkarolin added a commit that referenced this issue Nov 13, 2019
@mkarolin
Added tracking of missing .grdp files to scripts.
6b7e572 
Fixes #6907
This was referenced Nov 13, 2019
Merged
Merged
mkarolin added a commit that referenced this issue Nov 13, 2019
@mkarolin
Added tracking of missing .grdp files to scripts.
a82673f 
Fixes #6907
mkarolin added a commit that referenced this issue Nov 15, 2019
@mkarolin
Automatically add .grdp files when adding .grd.
7f8bc62 
Fixes #6907
mkarolin added a commit to brave/brave-core that referenced this issue Nov 18, 2019
@mkarolin
Updated grdp exclusions in transifex.py.
8949c38 
Fixes brave/brave-browser#6907

There is no need to exclude os_settings_strings.grdp and
xr_consent_ui_strings.grdp.

media_router_resources.grdp has been removed upstream.

Chromium change:

https://chromium.googlesource.com/chromium/src/+/edcf55b10dfe41c3ffa18bfbca8f07e62532ef74

commit edcf55b10dfe41c3ffa18bfbca8f07e62532ef74
Author: Takumi Fujimoto <takumif@chromium.org>
Date:   Tue Jul 9 16:36:20 2019 +0000

    Delete Media Router WebUI dialog resource files

    Delete JS/HTML/CSS files for chrome://media-router and its tests.

    We do not remove files related to chrome://media-router-internals
    because that is still in use.

    Bug: 900246
mkarolin added a commit to brave/brave-core that referenced this issue Nov 18, 2019
@mkarolin
Added missing .grdp files.
c24b217 
Fixes brave/brave-browser#6907
mkarolin added a commit that referenced this issue Nov 18, 2019
@mkarolin
Automatically add .grdp files when adding .grd.
151d255 
Fixes #6907
mkarolin added a commit that referenced this issue Nov 18, 2019
@mkarolin
Added tracking of missing .grdp files to scripts.
031a6a0 
Fixes #6907
mkarolin added a commit that referenced this issue Nov 19, 2019
@mkarolin
Added tracking of missing .grdp files to scripts.
94182bb 
Fixes #6907
@bbondy bbondy added this to the 1.3.x - Release milestone Jun 1, 2020
petemill pushed a commit to brave/brave-core that referenced this issue Jul 27, 2020
@mkarolin
Automatically add .grdp files when adding .grd.
a0111cc 
Fixes brave/brave-browser#6907
petemill pushed a commit to brave/brave-core that referenced this issue Jul 28, 2020
@mkarolin
Automatically add .grdp files when adding .grd.
a175c32 
Fixes brave/brave-browser#6907
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mkarolin mkarolin

Labels
dev-concern QA/No release-notes/exclude
Projects
None yet
Milestone
1.3.x - Release
2 participants
@bbondy @mkarolin