-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
users are prompted to Sign into Brave after saving credit card info #7219
Comments
Adding 1.1.x milestone as this is likely a C79 regression we want resolved before releasing. |
I believe this is a bug upstream; I filed https://bugs.chromium.org/p/chromium/issues/detail?id=1031307 Looking at an easy fix for us 👍 |
Verification PASSED on
Example of notification/modal without Verification passed on
Verified test plan from brave/brave-core#4151 Verification passed on
Verified test plan from brave/brave-core#4151 |
Description
On C79 builds users are being asked to 'Sign into Brave' after saving credit card info. Similar to #1363.
On C78 builds this does not occur.
Steps to Reproduce
Actual result:
This should not appear after saving credit card info:
And when you click on the credit card icon in the URL Bar:
Expected result:
No prompt to sign in to Brave after saving CC info.
When you click on credit card icon in URL bar, there shouldn't be a message at the bottom of the popup asking you to sign in:
This is how this works on 1.0.1 C78:
Reproduces how often:
easily
Brave version (brave://version info)
Version/Channel Information:
Other Additional Information:
Miscellaneous Information:
Originally reported by @AndriusA on Nightly.
I also checked passwords, saving passwords on 1.1.18 does not prompt you to sign into Brave after saving them.
cc @mkarolin @bsclifton @rebron @brave/legacy_qa
The text was updated successfully, but these errors were encountered: