Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

users are prompted to Sign into Brave after saving credit card info #7219

Closed
LaurenWags opened this issue Dec 5, 2019 · 3 comments · Fixed by brave/brave-core#4151
Closed

Comments

@LaurenWags
Copy link
Member

Description

On C79 builds users are being asked to 'Sign into Brave' after saving credit card info. Similar to #1363.

On C78 builds this does not occur.

Steps to Reproduce

  1. Navigate to a site such as https://mqi.ie/donate/
  2. Enter information and submit
  3. Save Credit Card info when prompted from URL bar

Actual result:

This should not appear after saving credit card info:
Screen Shot 2019-12-05 at 11 13 54 AM

And when you click on the credit card icon in the URL Bar:
Screen Shot 2019-12-05 at 11 14 28 AM

creditcard-test1118

Expected result:

No prompt to sign in to Brave after saving CC info.

When you click on credit card icon in URL bar, there shouldn't be a message at the bottom of the popup asking you to sign in:
Screen Shot 2019-12-05 at 11 11 22 AM

This is how this works on 1.0.1 C78:
creditcard-test101

Reproduces how often:

easily

Brave version (brave://version info)

Brave 1.1.18 Chromium: 79.0.3945.56 (Official Build) (64-bit)
Revision 73cc6bf591f792b99f8fc7cdfb8addedbd084bf8-refs/branch-heads/3945@{#788}
OS macOS Version 10.13.6 (Build 17G5019)

Version/Channel Information:

  • Can you reproduce this issue with the current release? no, not with 1.0.1
  • Can you reproduce this issue with the beta channel? unsure
  • Can you reproduce this issue with the dev channel? unsure
  • Can you reproduce this issue with the nightly channel? yes, reported by @AndriusA

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Does the issue resolve itself when disabling Brave Rewards? n/a
  • Is the issue reproducible on the latest version of Chrome? yes

Miscellaneous Information:

Originally reported by @AndriusA on Nightly.

I also checked passwords, saving passwords on 1.1.18 does not prompt you to sign into Brave after saving them.

cc @mkarolin @bsclifton @rebron @brave/legacy_qa

@LaurenWags
Copy link
Member Author

Adding 1.1.x milestone as this is likely a C79 regression we want resolved before releasing.

@bsclifton
Copy link
Member

I believe this is a bug upstream; I filed https://bugs.chromium.org/p/chromium/issues/detail?id=1031307

Looking at an easy fix for us 👍

@kjozwiak
Copy link
Member

kjozwiak commented Dec 9, 2019

Verification PASSED on macOS 10.15.1 x64 using the following build:

Brave 1.1.19 Chromium: 79.0.3945.70 (Official Build) (64-bit)
Revision 65868db27916cebde51fc2465c9b34761e6383e2-refs/branch-heads/3945@{#869}
OS macOS Version 10.15.1 (Build 19B88)
  • ensured that saving CC info via https://dump-truck.appspot.com/usecase-address_and_cc_on_same_page/address_and_cc.html doesn't display the Sign in to Brave text.
  • ensured that clicking on X dismisses the modal but is still available via the URL
  • ensured that clicking on
  • ensured CC info isn't being saved under brave://settings/payments when selecting No Thanks
  • ensured CC info is being saved correctly under brave://settings/payments when selecting Save and ensuring a Card Saved message is being displayed in the URL
  • ensured Manage addresses correctly opens chrome://settings/addresses
  • ensured Manage payment methods correctly opens chrome://settings/payments

Example of notification/modal without Sign in to Brave being displayed:

Screen Shot 2019-12-09 at 2 14 24 AM

Verification passed on

Brave 1.1.19 Chromium: 79.0.3945.70 (Official Build) (64-bit)
Revision 65868db27916cebde51fc2465c9b34761e6383e2-refs/branch-heads/3945@{#869}
OS Ubuntu 18.04 LTS

Verified test plan from brave/brave-core#4151

image

Verification passed on

Brave 1.1.19 Chromium: 79.0.3945.70 (Official Build) (64-bit)
Revision 65868db27916cebde51fc2465c9b34761e6383e2-refs/branch-heads/3945@{#869}
OS Windows 7 Service Pack 1 (Build 7601.24530)

Verified test plan from brave/brave-core#4151

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment