Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brave.P3A.SentAnswersCount defaults to highest value #7261

Closed
LaurenWags opened this issue Dec 7, 2019 · 2 comments
Closed

Brave.P3A.SentAnswersCount defaults to highest value #7261

LaurenWags opened this issue Dec 7, 2019 · 2 comments

Comments

@LaurenWags
Copy link
Member

Description

Found while testing #6285

While testing P3A on a clean profile, I noticed that Brave.P3A.SentAnswersCount defaults to 3 (which is the highest value) in local state. Per discussion with @iefremov this is a bug.

Steps to Reproduce

  1. Launch 1.1.x with clean profile.
  2. Navigate to brave://local state.

Actual result:

see something like this

         "Brave.P3A.SentAnswersCount": {
            "sent": false,
            "value": "3"
         },

3 corresponds to a response of 10 or more per stats

Expected result:

I'd expect it to default to the lowest value

Reproduces how often:

easily

Brave version (brave://version info)

Brave 1.1.18 Chromium: 79.0.3945.56 (Official Build) (64-bit)
Revision 73cc6bf591f792b99f8fc7cdfb8addedbd084bf8-refs/branch-heads/3945@{#788}
OS macOS Version 10.13.6 (Build 17G5019)

Version/Channel Information:

  • Can you reproduce this issue with the current release? n/a
  • Can you reproduce this issue with the beta channel? unsure
  • Can you reproduce this issue with the dev channel? unsure
  • Can you reproduce this issue with the nightly channel? unsure

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @iefremov @bsclifton @brave/legacy_qa

@bsclifton
Copy link
Member

Fixed with brave/brave-core#4145

(specifically, 1.1 was fixed with brave/brave-core@1be2459)

@LaurenWags
Copy link
Member Author

Per discussion with @iefremov and @bsclifton since this issue is still occurring in 1.1.x, logged a follow up issue, #7306, and marking this one as QA/No.

@LaurenWags LaurenWags added QA/No and removed QA/Yes labels Dec 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants