Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

P3A enabled status not updated in all windows when toggled #7289

Closed
bsclifton opened this issue Dec 9, 2019 · 1 comment · Fixed by brave/brave-core#4185
Closed

P3A enabled status not updated in all windows when toggled #7289

bsclifton opened this issue Dec 9, 2019 · 1 comment · Fixed by brave/brave-core#4185
Assignees
@bsclifton
Labels
about-pages/rebrand Rebranding work on top of Chrome's Polymer-powered pages bug features/P3A QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/include
Milestone
1.4.x - Release

Comments

@bsclifton
Copy link
Member

Description

Found while addressing review feedback in brave/brave-core#4044

If P3A status changes while the UI is open, the page is not notified / updated in real time.

Steps to Reproduce

  1. Have two windows open
  2. Open brave://settings/privacy in both
  3. In one window, toggle the value for Automatically send completely private product analytics to Brave

Actual result:

Toggle doesn't happen in both windows. It only affects the window you did it from.

Expected result:

The other window should get notified of the change and update also.

Reproduces how often:

100%
@bsclifton bsclifton added bug about-pages/rebrand Rebranding work on top of Chrome's Polymer-powered pages QA/Yes QA/Test-Plan-Specified labels Dec 9, 2019
@bsclifton bsclifton added this to the 1.4.x - Nightly milestone Dec 9, 2019
@bsclifton bsclifton self-assigned this Dec 9, 2019
@bsclifton bsclifton mentioned this issue Dec 9, 2019
Merged
32 tasks
bsclifton added a commit to brave/brave-core that referenced this issue Dec 9, 2019
@bsclifton
Add listener for brave://settings/privacy to ensure P3A enabled value…
d056a21 
… is in sync

For example, if you had two windows with brave://settings/privacy open

Fixes brave/brave-browser#7289

This is something I missed while implementing #3242
@LaurenWags
Copy link
Member

LaurenWags commented Feb 11, 2020 •
edited by btlechowski
Loading

Verified passed with

Brave 1.4.82 Chromium: 80.0.3987.87 (Official Build) beta (64-bit)
Revision 449cb163497b70dbf98d389f54e38e85d4c59b43-refs/branch-heads/3987@{#801}
OS macOS Version 10.14.6 (Build 18G103)
  • Verified STR from description

Verification passed on

Brave 1.4.84 Chromium: 80.0.3987.87 (Official Build) beta (64-bit)
Revision 449cb163497b70dbf98d389f54e38e85d4c59b43-refs/branch-heads/3987@{#801}
OS Windows 10 OS Version 1803 (Build 17134.1006)
  • Verified STR from the description
    Toggle the value in one window affects settings in the second window
    image

Verification passed on

Brave 1.4.84 Chromium: 80.0.3987.87 (Official Build) beta (64-bit)
Revision 449cb163497b70dbf98d389f54e38e85d4c59b43-refs/branch-heads/3987@{#801}
OS Ubuntu 18.04 LTS
  • Verified STR from the description
    Toggle the value in one window affects settings in the second window
    image

@kjozwiak kjozwiak mentioned this issue Feb 25, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bsclifton bsclifton

Labels
about-pages/rebrand Rebranding work on top of Chrome's Polymer-powered pages bug features/P3A QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/include
Projects
None yet
Milestone
1.4.x - Release
Development

Successfully merging a pull request may close this issue.

Add listener for brave://settings/privacy to ensure P3A enabled value is in sync brave/brave-core
4 participants
@bsclifton @LaurenWags @btlechowski @GeetaSarvadnya