Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some bookmarks are not synced in 1.5.x #7893

Closed
btlechowski opened this issue Jan 23, 2020 · 4 comments · Fixed by brave/brave-core#4420
Closed

Some bookmarks are not synced in 1.5.x #7893

btlechowski opened this issue Jan 23, 2020 · 4 comments · Fixed by brave/brave-core#4420
Assignees
@AlexeyBarabash
Labels
feature/sync priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes regression release-notes/exclude
Milestone
1.3.x - Release

Comments

@btlechowski
Copy link

btlechowski commented Jan 23, 2020 •
edited
Loading

Issue is reproducible in 1.5.x. Not reproducible in 1.3.x and 1.4.x

Steps to Reproduce

  1. Clean profile DeviceA and DeviceB
  2. DeviceA: open interia.pl and bookmark it
  3. DeviceA: create bookmark folder named DeviceA
  4. DeviceB: open youtube.com and bookmark it
  5. DeviceB: create bookmark folder named DeviceB
  6. DeviceA: create sync chain and copy code words
  7. DeviceB: enter code words
  8. Wait for sync

DeviceA: Windows 7x64
DeviceB: Ubuntu 18.04LTS

Actual result:

Some bookmarks are missing
DeviceA is missing youtube.com bookmark:
image

DeviceB is missing interia.pl bookmark:
image

Note: Browser relaunch does not fix the issue

Expected result:

All bookmarks and bookmark folders are synced

Reproduces how often:

100% repro rate with above STR

Brave version (brave://version info)

Reproducible on

Brave 1.5.53 Chromium: 79.0.3945.130 (Official Build) nightly (64-bit)
Revision e22de67c28798d98833a7137c0e22876237fc40a-refs/branch-heads/3945@{#1047}
OS Windows 7 Service Pack 1 (Build 7601.24544)
Brave 1.5.53 Chromium: 79.0.3945.130 (Official Build) nightly (64-bit)
Revision e22de67c28798d98833a7137c0e22876237fc40a-refs/branch-heads/3945@{#1047}
OS Linux

Not reproducible on

Brave 1.4.67 Chromium: 79.0.3945.130 (Official Build) dev (64-bit)
Revision e22de67c28798d98833a7137c0e22876237fc40a-refs/branch-heads/3945@{#1047}
OS Windows 7 Service Pack 1 (Build 7601.24544)
Brave 1.4.67 Chromium: 79.0.3945.130 (Official Build) dev (64-bit)
Revision e22de67c28798d98833a7137c0e22876237fc40a-refs/branch-heads/3945@{#1047}
OS Linux
Brave 1.3.99 Chromium: 79.0.3945.130 (Official Build) beta (64-bit)
Revision e22de67c28798d98833a7137c0e22876237fc40a-refs/branch-heads/3945@{#1047}
OS Windows 7 Service Pack 1 (Build 7601.24544)
Brave 1.3.99 Chromium: 79.0.3945.130 (Official Build) beta (64-bit)
Revision e22de67c28798d98833a7137c0e22876237fc40a-refs/branch-heads/3945@{#1047}
OS Linux

cc @brave/legacy_qa @jsecretan @AlexeyBarabash @darkdh @rebron
@btlechowski btlechowski changed the title Some bookmarks are not synced Some bookmarks are not synced in 1.5.x Jan 23, 2020
@btlechowski btlechowski mentioned this issue Jan 23, 2020
Merged
32 tasks
@AlexeyBarabash AlexeyBarabash self-assigned this Jan 23, 2020
@jsecretan jsecretan added the priority/P2 A bad problem. We might uplift this to the next planned release. label Jan 23, 2020
@btlechowski
Copy link
Author

Also reproduced with Windows 7x64 and Windows 10x64.
The same bookmarks are missing: interia.pl on DeviceB and youtube.com on DeviceA.

DeviceA:

Brave 1.5.53 Chromium: 79.0.3945.130 (Official Build) nightly (64-bit)
Revision e22de67c28798d98833a7137c0e22876237fc40a-refs/branch-heads/3945@{#1047}
OS Windows 10 OS Version 1909

DeviceB:

Brave 1.5.53 Chromium: 79.0.3945.130 (Official Build) nightly (64-bit)
Revision e22de67c28798d98833a7137c0e22876237fc40a-refs/branch-heads/3945@{#1047}
OS Windows 7 Service Pack 1 (Build 7601.24544)

@AlexeyBarabash
Copy link
Contributor

Thanks @btlechowski . I can confirm I am able to reproduce it.

@AlexeyBarabash AlexeyBarabash mentioned this issue Jan 24, 2020
Merged
32 tasks
@btlechowski
Copy link
Author

Verification passed on

Brave 1.5.62 Chromium: 79.0.3945.130 (Official Build) nightly (64-bit)
Revision e22de67c28798d98833a7137c0e22876237fc40a-refs/branch-heads/3945@{#1047}
OS Windows 7 Service Pack 1 (Build 7601.24544)

Verified STR from the description

Verification passed on

Brave 1.5.62 Chromium: 79.0.3945.130 (Official Build) nightly (64-bit)
Revision e22de67c28798d98833a7137c0e22876237fc40a-refs/branch-heads/3945@{#1047}
OS Ubuntu 18.04 LTS

Verified STR from the description

This issues needs to be retested after uplift to 1.3.x

@btlechowski btlechowski added this to the 1.5.x - Nightly milestone Jan 27, 2020
@brave-builds brave-builds mentioned this issue Jan 30, 2020
Merged
4 tasks
@brave-builds brave-builds mentioned this issue Jan 30, 2020
Merged
4 tasks
@kjozwiak kjozwiak modified the milestones: 1.5.x - Nightly, 1.3.x - Beta Feb 3, 2020
This was referenced Feb 4, 2020
Closed
Closed
Closed
@btlechowski
Copy link
Author

btlechowski commented Feb 4, 2020 •
edited by LaurenWags
Loading

Verification passed on

Brave 1.3.109 Chromium: 79.0.3945.130 (Official Build) beta (64-bit)
Revision e22de67c28798d98833a7137c0e22876237fc40a-refs/branch-heads/3945@{#1047}
OS Ubuntu 18.04 LTS

Verification passed on

Brave 1.3.109 Chromium: 79.0.3945.130 (Official Build) beta (64-bit)
Revision e22de67c28798d98833a7137c0e22876237fc40a-refs/branch-heads/3945@{#1047}
OS Windows 7 Service Pack 1 (Build 7601.24544)

Verified test plan from the description. Also verified by switching devices.

image

Verification passed on

Brave 1.3.110 Chromium: 80.0.3987.78 (Official Build) (64-bit)
Revision cb5aa81cb0a3a2c674b93bc7ffb34a86cd3b4802-refs/branch-heads/3987@{#752}
OS Windows 10 OS Version 1803 (Build 17134.1006)
  • Verified STR mentioned in the description

image

Verification passed with

Brave 1.3.111 Chromium: 80.0.3987.85 (Official Build) (64-bit)
Revision 583b05dfa4ffc657f0f7c5cc13f53aa17c9a5bcf-refs/branch-heads/3987@{#791}
OS macOS Version 10.14.6 (Build 18G103)
  • Verified STR from description. Did two tests:
    • one where macOS laptop was Device A and Ubuntu VM was Device B
    • one where Ubuntu VM was Device A and macOS laptop was Device B.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AlexeyBarabash AlexeyBarabash

Labels
feature/sync priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes regression release-notes/exclude
Projects
None yet
Milestone
1.3.x - Release
Development

Successfully merging a pull request may close this issue.

Ignore bookmark icon url when browser gets bookmark form sync cloud brave/brave-core
7 participants
@jsecretan @kjozwiak @bsclifton @AlexeyBarabash @LaurenWags @btlechowski @GeetaSarvadnya