Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add speedreader button via --enable-speedreader #8416

Closed
rebron opened this issue Feb 26, 2020 · 5 comments
Closed

Add speedreader button via --enable-speedreader #8416

rebron opened this issue Feb 26, 2020 · 5 comments
Assignees
Labels
design A design change, especially one which needs input from the design team feature/speedreader priority/P3 The next thing for us to work on. It'll ride the trains. QA/No release-notes/exclude

Comments

@rebron
Copy link
Collaborator

rebron commented Feb 26, 2020

Description

Add speedreader button via --enable-speedreader.
Remainder of speedreader feature outlined in #9810.

Can only view the speedreader button, states, and function with the command line above. Users should otherwise not see the speedreader button.

@rebron rebron added priority/P3 The next thing for us to work on. It'll ride the trains. design A design change, especially one which needs input from the design team feature/speedreader labels Feb 26, 2020
@karenkliu
Copy link

@AndriusA Designs added!

@petemill
Copy link
Member

Should the speedreader ON page use a simple dark theme in dark mode? @karenkliu

@karenkliu
Copy link

@petemill Good Q! You're right, pages that are speed-readable in dark theme should have that styling carry over to the page content. I've updated the designs.

@iefremov
Copy link
Contributor

iefremov commented Apr 16, 2020

For QA: The promo bubble was not implemented in this issue (there is a separate ticket #9262).

To enable speedreader pass --enable-speedreader. To whitelist certain sites use e.g. speedreader-whitelist="https://bbc.com/*;"

Specific details of the distilled page CSS are also out of this issue scope. Dark theme is not yet supported by the stylesheet.

@rebron rebron added this to the 1.9.x - Nightly milestone Apr 20, 2020
@rebron rebron added QA/No and removed QA/Blocked labels May 17, 2020
@rebron rebron changed the title Add Speedreader view Add speedreader button via --enable-speedreader May 17, 2020
@LaurenWags
Copy link
Member

Using

Brave | 1.9.70 Chromium: 81.0.4044.138 (Official Build) (64-bit)
-- | --
Revision | 8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{#999}
OS | macOS Version 10.14.6 (Build 18G3020)

Confirmed if no --enable-speedreader flag is used, there is no speedreader icon:
Screen Shot 2020-05-18 at 11 20 19 AM

Confirmed if using --enable-speedreader flag, speedreader icon is shown:
Screen Shot 2020-05-18 at 11 19 14 AM

Confirmed when icon is shown, I can interact with it (click on it).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design A design change, especially one which needs input from the design team feature/speedreader priority/P3 The next thing for us to work on. It'll ride the trains. QA/No release-notes/exclude
Projects
None yet
Development

No branches or pull requests

6 participants