Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

certain extensions breaking due to WebSQL being disabled #8542

Closed
kjozwiak opened this issue Mar 5, 2020 · 1 comment · Fixed by brave/brave-core#4842
Closed

certain extensions breaking due to WebSQL being disabled #8542

kjozwiak opened this issue Mar 5, 2020 · 1 comment · Fixed by brave/brave-core#4842

Comments

@kjozwiak
Copy link
Member

kjozwiak commented Mar 5, 2020

Description

It appears that some extensions are failing due to us disabling WebSQL as per brave/brave-core#4463.

Screen Shot 2020-03-04 at 9 55 19 PM (1)

Screen Shot 2020-03-04 at 11 48 38 PM

Steps to Reproduce

  1. install 1.6.56 CR: 80.0.3987.122 (Dev) or 1.7.39 CR: 80.0.3987.132 (Nightly)
  2. install https://chrome.google.com/webstore/detail/speed-dial-fvd-new-tab-pa/llaficoajjainaijghjlofdfmbjpebpa/related?hl=en

Actual result:

Screen Shot 2020-03-05 at 12 00 15 AM

Expected result:

Screen Shot 2020-03-04 at 11 55 21 PM

Reproduces how often:

100% reproducible using the above STR.

Brave version (brave://version info)

Brave | 1.6.56 Chromium: 80.0.3987.122 (Official Build) dev (64-bit)
-- | --
Revision | cf72c4c4f7db75bc3da689cd76513962d31c7b52-refs/branch-heads/3987@{#943}
OS | macOS Version 10.15.3 (Build 19D76)
Brave | 1.7.39 Chromium: 80.0.3987.132 (Official Build) nightly (64-bit)
-- | --
Revision | fcea73228632975e052eb90fcf6cd1752d3b42b4-refs/branch-heads/3987@{#974}
OS | macOS Version 10.15.3 (Build 19D76)

Version/Channel Information:

  • Can you reproduce this issue with the current release? No
  • Can you reproduce this issue with the beta channel? No
  • Can you reproduce this issue with the dev channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Does the issue resolve itself when disabling Brave Rewards? N/A
  • Is the issue reproducible on the latest version of Chrome? N/A

Miscellaneous Information:

CCing @bsclifton @rebron @brave/legacy_qa

bsclifton added a commit to brave/brave-core that referenced this issue Mar 5, 2020
Speed dial extension was affected; may impact others too.

Fixes brave/brave-browser#8542

-----

Revert "Merge pull request #4463 from brave/disable_websql"

This reverts commit a50fa1d, reversing
changes made to cd4edd3.
@bsclifton bsclifton added this to the 1.7.x - Nightly milestone Mar 5, 2020
@kjozwiak kjozwiak modified the milestones: 1.7.x - Nightly, 1.6.x - Dev Mar 5, 2020
@bbondy bbondy modified the milestones: 1.6.x - Beta, 1.7.x - Dev Mar 10, 2020
@kjozwiak
Copy link
Member Author

kjozwiak commented Mar 24, 2020

Verification PASSED on macOS 10.15.3 x64 Catalina using the following build:

Brave | 1.7.71 Chromium: 80.0.3987.149 (Official Build) dev (64-bit)
-- | --
Revision | 5f4eb224680e5d7dca88504586e9fd951840cac6-refs/branch-heads/3987_137@{#16}
OS | macOS Version 10.15.3 (Build 19D76)

Screen Shot 2020-03-24 at 11 45 43 AM

Screen Shot 2020-03-24 at 11 48 22 AM

Verification passed on

Brave 1.7.71 Chromium: 80.0.3987.149 (Official Build) dev (64-bit)
Revision 5f4eb224680e5d7dca88504586e9fd951840cac6-refs/branch-heads/3987_137@{#16}
OS Ubuntu 18.04 LTS

Verified test plan from the description

image

image

Verification passed on

Brave 1.7.73 Chromium: 80.0.3987.149 (Official Build) dev (64-bit)
Revision 5f4eb224680e5d7dca88504586e9fd951840cac6-refs/branch-heads/3987_137@{#16}
OS Windows 10 OS Version 1803 (Build 17134.1006)

image

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment