Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for different default search engines based on region #893

Closed
rebron opened this issue Aug 30, 2018 · 2 comments · Fixed by brave/brave-core#516
Closed

Allow for different default search engines based on region #893

rebron opened this issue Aug 30, 2018 · 2 comments · Fixed by brave/brave-core#516

Comments

@rebron
Copy link
Collaborator

rebron commented Aug 30, 2018

Test plan

See brave/brave-core#516

Original Description

(Work on browser-laptop was done with brave/browser-laptop#14713)

Brave should use region detection when considering how to set the default search engine (globally and for private tabs)

For example, if I'd like to default to bing.com for Brazil, this should be possible. Currently, the default search is applied regardless of region

The region detection should happen via Node (ex: looking at the computer settings)

Carrying over from browser-laptop
brave/browser-laptop#14647

@bbondy bbondy added this to the Backlog milestone Aug 30, 2018
@bsclifton bsclifton modified the milestones: 1.x Backlog, Releasable builds 0.55.x Sep 11, 2018
@bsclifton
Copy link
Member

The default search engines (by country) are set in Chromium here:
src/components/search_engines/template_url_prepopulate_data.cc

The first one in the list is set as the default.

There's an accompanying file which has the specifics for each search engine (URL, suggest URL, favicon URL, etc):
src/components/search_engines/prepopulated_engines.json

mkarolin added a commit to brave/brave-core that referenced this issue Oct 1, 2018
Fixes brave/brave-browser#731

Overrode Chromium's set of prepopulated search engines with our own set and regional defaults.
Added new unit tests to:
 * check for duplicate prepopulate ids and keywords
 * check for correct default search engine based on locale
 * check that prepopulated engines have all required fields
@srirambv
Copy link
Contributor

srirambv commented Oct 5, 2018

Verification Passed on

Brave 0.55.11 Chromium: 70.0.3538.35 (Official Build) beta (64-bit)
Revision 28dcb499844fa40c28d5f62e337876cb936f79f5-refs/branch-heads/3538@{#678}
OS Linux
  • Verified setting device language to de_DE.UTF-8 or fr_FR.UTF-8 changes default search engine to Qwant
  • Verified setting FR/DE language shows the localized version of Yahoo page in search list

Verified passed with

Brave 0.55.11 Chromium: 70.0.3538.35 (Official Build) beta(64-bit)
Revision 28dcb499844fa40c28d5f62e337876cb936f79f5-refs/branch-heads/3538@{#678}
OS Mac OS X
  • Verified all scenarios in test plan

Verification Passed on

Brave 0.55.12 Chromium: 70.0.3538.45 (Official Build) beta (64-bit)
Revision cbdc32e4334458954e9def214d7e5fa1ca1960eb-refs/branch-heads/3538@{#830}
OS Windows
  • Verified all scenarios in test plan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment