-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow for different default search engines based on region #893
Labels
browser-laptop-parity
feature/global-settings
Settings at browser level independent of shields settings
feature/search
l10n
QA Pass-Linux
QA Pass-macOS
QA Pass-Win64
QA/Test-Plan-Specified
QA/Yes
release-notes/exclude
Milestone
Comments
The default search engines (by country) are set in Chromium here: The first one in the list is set as the default. There's an accompanying file which has the specifics for each search engine (URL, suggest URL, favicon URL, etc): |
11 tasks
bsclifton
added
l10n
feature/search
feature/global-settings
Settings at browser level independent of shields settings
browser-laptop-parity
QA/Yes
QA/Test-Plan-Specified
release-notes/include
labels
Sep 28, 2018
mkarolin
added a commit
to brave/brave-core
that referenced
this issue
Oct 1, 2018
Fixes brave/brave-browser#731 Overrode Chromium's set of prepopulated search engines with our own set and regional defaults. Added new unit tests to: * check for duplicate prepopulate ids and keywords * check for correct default search engine based on locale * check that prepopulated engines have all required fields
Verification Passed on
Verified passed with
Verification Passed on
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
browser-laptop-parity
feature/global-settings
Settings at browser level independent of shields settings
feature/search
l10n
QA Pass-Linux
QA Pass-macOS
QA Pass-Win64
QA/Test-Plan-Specified
QA/Yes
release-notes/exclude
Test plan
See brave/brave-core#516
Original Description
(Work on
browser-laptop
was done with brave/browser-laptop#14713)Brave should use region detection when considering how to set the default search engine (globally and for private tabs)
For example, if I'd like to default to bing.com for Brazil, this should be possible. Currently, the default search is applied regardless of region
The region detection should happen via Node (ex: looking at the computer settings)
Carrying over from browser-laptop
brave/browser-laptop#14647
The text was updated successfully, but these errors were encountered: