Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bring SpeedReader +FFI repos into brave-core #8978

Closed
AndriusA opened this issue Apr 2, 2020 · 1 comment · Fixed by brave/brave-core#5142
Closed

Bring SpeedReader +FFI repos into brave-core #8978

AndriusA opened this issue Apr 2, 2020 · 1 comment · Fixed by brave/brave-core#5142
Assignees
@AndriusA
Labels
feature/speedreader OS/Desktop QA/No release-notes/exclude
Milestone
1.10.x - Release

Comments

@AndriusA
Copy link

AndriusA commented Apr 2, 2020

It has been decided that all projects when possible should be moved to within brave-core instead of linking via vendor DEPS for easier management and versioning.
@AndriusA AndriusA self-assigned this Apr 2, 2020
@AndriusA AndriusA mentioned this issue Apr 2, 2020
Merged
32 tasks
@bsclifton bsclifton added this to the 1.10.x - Nightly milestone May 6, 2020
@bsclifton
Copy link
Member

bsclifton commented May 6, 2020 •
edited
Loading

Added missing milestone; also added QA/No label. Please add QA/Yes and steps if any manual testing is required
cc: @bridiver

@rebron rebron mentioned this issue May 17, 2020
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AndriusA AndriusA

Labels
feature/speedreader OS/Desktop QA/No release-notes/exclude
Projects
None yet
Milestone
1.10.x - Release
Development

Successfully merging a pull request may close this issue.

Speedreader repository moved into brave core brave/brave-core
3 participants
@AndriusA @bsclifton @rebron