Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to show tabs in page theme color #905

Closed
bsclifton opened this issue Sep 1, 2018 · 4 comments
Closed

Option to show tabs in page theme color #905

bsclifton opened this issue Sep 1, 2018 · 4 comments
Labels
browser-laptop-parity closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. feature/tabs-bar

Comments

@bsclifton
Copy link
Member

In the live browser-laptop code-base, there is a setting (defaulted to enabled) where tabs have a "theme color" which is determined at load time (color is basically coming from sampling the favicon colors, if I remember correctly).

Here's an example showing the tab color for GitHub. It helps the page blend into the tab:
screen shot 2018-08-31 at 10 35 25 pm

In browser-laptop, the setting is put into the tabs section
screen shot 2018-08-31 at 10 32 44 pm

@srirambv
Copy link
Contributor

Personally i'd down vote this as sometime the tab colour is too distracting and harsh. Favicons with same theme colour doesnt look distinguishable. Looks like enitre tab is filled with the tab colour. Example is Twitter icon is blue and page theme is blue so entire tab becomes blue

@bbondy bbondy modified the milestones: 2.x Backlog, 1.x Backlog Sep 30, 2018
@Jacalz
Copy link
Contributor

Jacalz commented Oct 26, 2018

I agree with @srirambv on this and it doesn't really fit with tabs on the top 😓

@rebron rebron modified the milestone: 1.x Backlog Feb 7, 2019
@LesterCovax
Copy link

I would greatly appreciate this feature, as when you have many tabs open, it can be hard to quickly distinguish which one is active. My suggestion would be to have the tab highlighted with the opposite color of the theme though, as it would be less distracting.

image

To those that don't like the idea, or wouldn't use it, that's why things like feature flags / options exist. Not sure why you'd thwart the addition of something some would find useful, and could even be disabled by default :suspect:

@bsclifton bsclifton added the closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. label Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
browser-laptop-parity closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. feature/tabs-bar
Projects
None yet
Development

No branches or pull requests

7 participants