Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade from 72.0.3626.64 to 72.0.3626.71 #3087

Merged
merged 1 commit into from
Jan 24, 2019
Merged

Upgrade from 72.0.3626.64 to 72.0.3626.71 #3087

merged 1 commit into from
Jan 24, 2019

Conversation

bbondy
Copy link
Member

@bbondy bbondy commented Jan 24, 2019

Fix #3086

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Requested a security/privacy review as needed.

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions.

@bbondy bbondy added this to the 0.62.x - Nightly milestone Jan 24, 2019
@bbondy bbondy self-assigned this Jan 24, 2019
@bbondy bbondy requested a review from emerick January 24, 2019 21:09
emerick
emerick approved these changes Jan 24, 2019
View reviewed changes
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This was referenced Jan 24, 2019
Merged
Merged
Merged
@bbondy bbondy merged commit 537a288 into master Jan 24, 2019
@bbondy bbondy deleted the 72.0.3626.71 branch January 24, 2019 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emerick emerick emerick approved these changes

Assignees

@bbondy bbondy

Labels
None yet
Projects
None yet
Milestone
0.62.x - Release (Release Channel)
Development

Successfully merging this pull request may close these issues.
2 participants
@bbondy @emerick