From e847af57b96f621b98de1757f245c93149122868 Mon Sep 17 00:00:00 2001 From: Jocelyn Liu Date: Fri, 29 Jun 2018 21:27:57 -0700 Subject: [PATCH 1/2] Add brave_page_visibility.js into chrome's settings resource --- lib/l10nUtil.js | 6 ++++++ lib/util.js | 1 + 2 files changed, 7 insertions(+) diff --git a/lib/l10nUtil.js b/lib/l10nUtil.js index e827aad8c47f..74af3682a962 100644 --- a/lib/l10nUtil.js +++ b/lib/l10nUtil.js @@ -40,6 +40,11 @@ const chromiumSettingsResourcesPath = path.resolve(path.join(srcDir, 'chrome', ' const autoGeneratedWarning = '' +const pageVisibility = ' \n' + module.exports.getSourceStringPaths = () => { return [ braveStringsPath, @@ -73,6 +78,7 @@ module.exports.rebaseBraveStringFilesOnChromiumL10nFiles = (path) => .replace(' components/components_chromium_strings.grd fs.copySync(path.join(braveAppDir, 'strings'), path.join(chromeComponentsDir, 'strings')) + fs.copySync(path.join(braveResourcesDir, 'settings', 'brave_page_visibility.js'), path.join(chromeResourcesDir, 'settings', 'brave_page_visibility.js')) }, // Chromium compares pre-installed midl files and generated midl files from IDL during the build to check integrity. From 6d83eb9c28937b9909163fc68239e1e4e1553f3c Mon Sep 17 00:00:00 2001 From: Jocelyn Liu Date: Sun, 1 Jul 2018 10:23:40 -0700 Subject: [PATCH 2/2] add browser_resources --- lib/l10nUtil.js | 6 +++++- lib/util.js | 3 +++ 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/lib/l10nUtil.js b/lib/l10nUtil.js index 74af3682a962..766a88a7e6ca 100644 --- a/lib/l10nUtil.js +++ b/lib/l10nUtil.js @@ -23,6 +23,7 @@ const braveMdExtensionsPartPath = path.resolve(path.join(srcDir, 'brave', 'app', const braveExtensionsResourcesPath = path.resolve(path.join(srcDir, 'brave', 'browser', 'resources', 'md_extensions', 'extensions_resources.grd')) const braveSettingsResourcesPath = path.resolve(path.join(srcDir, 'brave', 'browser', 'resources', 'settings', 'settings_resources.grd')) +const braveBrowserResourcesPath = path.resolve(path.join(srcDir, 'brave', 'browser', 'browser_resources.grd')) // Chromium string paths const chromiumStringsPath = path.resolve(path.join(srcDir, 'chrome', 'app', 'chromium_strings.grd')) @@ -37,6 +38,7 @@ const chromiumMdExtensionsPartPath = path.resolve(path.join(srcDir, 'chrome', 'a const chromiumExtensionsResourcesPath = path.resolve(path.join(srcDir, 'chrome', 'browser', 'resources', 'md_extensions', 'extensions_resources.grd')) const chromiumSettingsResourcesPath = path.resolve(path.join(srcDir, 'chrome', 'browser', 'resources', 'settings', 'settings_resources.grd')) +const chromiumBrowserResourcesPath = path.resolve(path.join(srcDir, 'chrome', 'browser', 'browser_resources.grd')) const autoGeneratedWarning = '' @@ -70,7 +72,8 @@ module.exports.rebaseBraveStringFilesOnChromiumL10nFiles = (path) => [chromiumSettingsStringsPartPath]: braveSettingsStringsPartPath, [chromiumMdExtensionsPartPath]: braveMdExtensionsPartPath, [chromiumExtensionsResourcesPath]: braveExtensionsResourcesPath, - [chromiumSettingsResourcesPath]: braveSettingsResourcesPath + [chromiumSettingsResourcesPath]: braveSettingsResourcesPath, + [chromiumBrowserResourcesPath]: braveBrowserResourcesPath }).forEach(([sourcePath, destPath]) => fs.writeFileSync(destPath, fs.readFileSync(sourcePath, 'utf8') @@ -78,6 +81,7 @@ module.exports.rebaseBraveStringFilesOnChromiumL10nFiles = (path) => .replace('