Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade from Chromium 78.0.3904.108 to Chromium 79.0.3945.45 #7043

Closed
wants to merge 4 commits into from

Conversation

mkarolin
Copy link
Contributor

@mkarolin mkarolin commented Nov 20, 2019

Fixes #6588
Related PR brave/brave-core#4043

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions.

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@mkarolin mkarolin added this to the 1.3.x - Nightly milestone Nov 20, 2019
@mkarolin mkarolin self-assigned this Nov 20, 2019
@mkarolin mkarolin force-pushed the 79.0.3945.45 branch 3 times, most recently from 24d0ddd to 84ed5a4 Compare November 22, 2019 15:36
@mkarolin mkarolin changed the title Upgrade from Chromium 78.0.3904.108 to Chromium 79.0.3945.45 WIP: Upgrade from Chromium 78.0.3904.108 to Chromium 79.0.3945.45 Nov 22, 2019
@mkarolin mkarolin marked this pull request as ready for review November 22, 2019 16:44
@mkarolin mkarolin changed the title WIP: Upgrade from Chromium 78.0.3904.108 to Chromium 79.0.3945.45 Upgrade from Chromium 78.0.3904.108 to Chromium 79.0.3945.45 Nov 23, 2019
simonhong
simonhong previously approved these changes Nov 25, 2019
Copy link
Member

@simonhong simonhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bsclifton
bsclifton previously approved these changes Nov 25, 2019
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

yrliou
yrliou previously approved these changes Nov 25, 2019
salif
salif previously approved these changes Nov 25, 2019
bsclifton
bsclifton previously approved these changes Nov 25, 2019
yrliou
yrliou previously approved these changes Nov 25, 2019
@mkarolin
Copy link
Contributor Author

Closing in favor of #7140

@mkarolin mkarolin closed this Nov 27, 2019
@mkarolin mkarolin deleted the 79.0.3945.45 branch November 27, 2019 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade from Chromium 78.0.3904.108 to Chromium 79.0.3945.56
5 participants