From 51439b53bb23d9442cfa096ebb4b09a6f9bc5ae1 Mon Sep 17 00:00:00 2001 From: Shivan Kaul Sahib Date: Wed, 13 Apr 2022 09:27:32 -0700 Subject: [PATCH] Misc fixes for DeAMP (#12999) - Tweak DeAMP regexes to be lazy - The amp html attribute might have empty value i.e. amp="" - Move DeAMP (from Security & Privacy section) and ReduceLanguage (from bottom of brave://settings/shields) settings to be near-top of brave://settings/shields so as to separate them from other per-site privacy settings --- .../brave_personalization_options.html | 6 ------ .../default_brave_shields_page.html | 12 ++++++++++++ components/de_amp/browser/de_amp_util.cc | 5 +++-- 3 files changed, 15 insertions(+), 8 deletions(-) diff --git a/browser/resources/settings/brave_privacy_page/brave_personalization_options.html b/browser/resources/settings/brave_privacy_page/brave_personalization_options.html index 0e25b302314f..0114cfe2c087 100644 --- a/browser/resources/settings/brave_privacy_page/brave_personalization_options.html +++ b/browser/resources/settings/brave_privacy_page/brave_personalization_options.html @@ -54,12 +54,6 @@ sub-label="$i18n{statsUsagePingEnabledDesc}" on-settings-boolean-control-change="onStatsUsagePingEnabledChange_"> - - diff --git a/browser/resources/settings/default_brave_shields_page/default_brave_shields_page.html b/browser/resources/settings/default_brave_shields_page/default_brave_shields_page.html index 81edbd02cb04..4e9655888f3a 100644 --- a/browser/resources/settings/default_brave_shields_page/default_brave_shields_page.html +++ b/browser/resources/settings/default_brave_shields_page/default_brave_shields_page.html @@ -56,6 +56,18 @@ pref="{{prefs.brave.shields.stats_badge_visible}}" label="$i18n{showStatsBlockedBadgeLabel}"> + + + +
$i18n{adControlLabel}